All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Alexander Usyskin <alexander.usyskin@intel.com>,
	Nicol? Costanza <abitrules@yahoo.it>,
	Alex Burmashev <alex.burmashev@rosalab.ru>,
	LKML <linux-kernel@vger.kernel.org>
Subject: RE: mei: cancel stall timers in mei_reset
Date: Mon, 4 Nov 2013 18:48:48 +0300 (MSK)	[thread overview]
Message-ID: <1361817048.3583.1383580128332.JavaMail.root@collab.rosalab.ru> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B1AF00BC7@HASMSX106.ger.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

----- Original Message -----
> I would appreciate the full log and your .config 

I have attached the config and the log.

Meanwhile, I have found one suspicious place in the code that could be related: mei_reset() ignores the return value of mei_hw_start(). According to the logs, there was at least the following interesting call sequence before things went wrong:

mei_reset() => mei_hw_start() => .hw_start() callback, which is mei_me_hw_start() => mei_me_hw_ready_wait().

mei_me_hw_ready_wait() reported "wait hw ready failed" and returned -ETIMEDOUT, that error was propagated to mei_hw_start(). mei_reset(), however, does not check the return value of that function and goes on even if it returns an error: sets dev->dev_state to MEI_DEV_INIT_CLIENTS, calls mei_hbm_start_req(dev), etc.

I am not sure if this is intentional and if this is related to the problem, but still.

Regards,
Eugene

[-- Attachment #2: files.tar.bz2 --]
[-- Type: application/x-bzip-compressed-tar, Size: 62338 bytes --]

  reply	other threads:[~2013-11-04 15:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01 12:27 mei: cancel stall timers in mei_reset Eugene Shatokhin
2013-11-03  7:53 ` Winkler, Tomas
2013-11-04 15:48   ` Eugene Shatokhin [this message]
2013-11-05  8:07     ` Eugene Shatokhin
2013-11-05  9:58       ` Usyskin, Alexander
2013-11-05 11:46         ` Eugene Shatokhin
2013-11-05 11:49           ` Winkler, Tomas
2013-11-05 15:06             ` Eugene Shatokhin
2013-11-06  7:13             ` Eugene Shatokhin
2013-11-06 20:03               ` Winkler, Tomas
2013-11-07  6:37                 ` Eugene Shatokhin
2013-11-07 12:52                   ` Winkler, Tomas
2013-11-09 18:20                     ` Eugene Shatokhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361817048.3583.1383580128332.JavaMail.root@collab.rosalab.ru \
    --to=eugene.shatokhin@rosalab.ru \
    --cc=abitrules@yahoo.it \
    --cc=alex.burmashev@rosalab.ru \
    --cc=alexander.usyskin@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.