From: Johannes Berg <johannes@sipsolutions.net>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Fabio Rossi <rossi.f@inwind.it>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Ensure off-channel frames don't get queued
Date: Tue, 26 Feb 2013 21:16:45 +0100 [thread overview]
Message-ID: <1361909805.8440.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1361825885-13520-1-git-send-email-seth.forshee@canonical.com>
On Mon, 2013-02-25 at 14:58 -0600, Seth Forshee wrote:
> Commit 6c17b77b67587b9f9e3070fb89fe98cef3187131 (mac80211: Fix tx queue
> handling during scans) contains a bug that causes off-channel frames to
> get queued when they should be handed down to the driver for transmit.
> Prevent this from happening.
>
> Reported-by: Fabio Rossi <rossi.f@inwind.it>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> ---
>
> Fabio, this patch should fix the problem. Can you verify?
>
> Johannes, this prevents the off-channel frames from getting queued
> without affecting the fast path. It does however make the indentation
> awfully deep ...
Ugh .. I do see the bug, but the indentation is crap. I'll apply this
anyway, and then we can sort it out later.
johannes
next prev parent reply other threads:[~2013-02-26 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 18:18 regression with kernel 3.8 Fabio Rossi
2013-02-25 19:26 ` Seth Forshee
2013-02-25 20:58 ` [PATCH] mac80211: Ensure off-channel frames don't get queued Seth Forshee
2013-02-26 20:16 ` Johannes Berg [this message]
2013-02-25 22:38 ` regression with kernel 3.8 Johannes Berg
2013-02-26 19:13 ` Seth Forshee
-- strict thread matches above, loose matches on Subject: below --
2013-02-25 22:45 [PATCH] mac80211: Ensure off-channel frames don't get queued Fabio Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361909805.8440.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rossi.f@inwind.it \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.