From: Peter Hurley <peter@hurleysoftware.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
markus@trippelsdorf.de, linux-kernel@vger.kernel.org
Subject: Re: WARNING: at lib/idr.c:678 idr_find_slowpath+0x97/0xc0()
Date: Fri, 01 Mar 2013 17:10:44 -0500 [thread overview]
Message-ID: <1362175844.3221.7.camel@thor.lan> (raw)
In-Reply-To: <CAOS58YOg20+i3beJsHJjedJ2sOrRfAakc=Pj84bZF0BatEU9HQ@mail.gmail.com>
On Fri, 2013-03-01 at 13:56 -0800, Tejun Heo wrote:
> On Fri, Mar 1, 2013 at 1:54 PM, Peter Hurley <peter@hurleysoftware.com> wrote:
> >> The WARN_ON() is just for cases where someone might be doing something
> >> crazy with the previous behavior of ignoring high bit. Maybe I was
> >> being overly paranoid and we should just drop it from idr_find().
> >
> > Can we revert the __lock_timer patch as well then?
>
> I don't know. Andrew was worried about the type of timer id. For
> inotify, it's okay as the type is always int but it's not a bad idea
> to have some form of sanitizing if the type might deviate.
It's the other way around that would be the problem, if idr returned a
type that wasn't representable by timer_t.
IMO, idr should be the sanitizing; either the value is valid and found
or not. But that's just my opinion :)
Regards,
Peter Hurley
prev parent reply other threads:[~2013-03-01 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 9:08 WARNING: at lib/idr.c:678 idr_find_slowpath+0x97/0xc0() markus
2013-03-01 21:31 ` Andrew Morton
2013-03-01 21:35 ` Tejun Heo
2013-03-01 21:45 ` [PATCH] idr: remove WARN_ON_ONCE() on negative IDs Tejun Heo
2013-03-01 21:54 ` WARNING: at lib/idr.c:678 idr_find_slowpath+0x97/0xc0() Peter Hurley
2013-03-01 21:56 ` Tejun Heo
2013-03-01 22:10 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362175844.3221.7.camel@thor.lan \
--to=peter@hurleysoftware.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.