Re: [Qemu-devel] [PATCH v4 2/2] pci: Teach PCI Bridges about VGA routing

[Alex Williamson <alex.williamson@redhat.com>]

On Mon, 2013-03-04 at 09:39 +0800, Peter Maydell wrote:
> On 4 March 2013 01:21, Alex Williamson <alex.williamson@redhat.com> wrote:
> > --- a/hw/pci/pcie_port.c
> > +++ b/hw/pci/pcie_port.c
> > @@ -28,10 +28,12 @@ void pcie_port_init_reg(PCIDevice *d)
> >      pci_set_word(d->config + PCI_SEC_STATUS, 0);
> >
> >      /* Unlike conventional pci bridge, some bits are hardwired to 0. */
> > +#define  PCI_BRIDGE_CTL_VGA_16BIT       0x10    /* VGA 16-bit decode */
> 
> Shouldn't this #define be in pci_regs.h with the other PCI_BRIDGE_CTL_*
> constants?

See the existing define in pci.c.  pci_regs.h is derived from the Linux
kernel header, which is not 100% complete.  Ideally it would contain
this, but it doesn't currently so I'm following the existing example.
Thanks,

Alex

> >      pci_set_word(d->wmask + PCI_BRIDGE_CONTROL,
> >                   PCI_BRIDGE_CTL_PARITY |
> >                   PCI_BRIDGE_CTL_ISA |
> >                   PCI_BRIDGE_CTL_VGA |
> > +                 PCI_BRIDGE_CTL_VGA_16BIT | /* Req, but no alias support yet */
> >                   PCI_BRIDGE_CTL_SERR |
> >                   PCI_BRIDGE_CTL_BUS_RESET);
> >  }
> 
> thanks
> -- PMM