From: Will Deacon <will.deacon@arm.com>
To: penberg@kernel.org
Cc: kvm@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
Sasha Levin <levinsasha928@gmail.com>,
Will Deacon <will.deacon@arm.com>
Subject: [PATCH 1/2] kvm tools: init: fix usage of hlist iterators
Date: Mon, 4 Mar 2013 06:27:30 +0000 [thread overview]
Message-ID: <1362378451-15216-1-git-send-email-will.deacon@arm.com> (raw)
From: Marc Zyngier <marc.zyngier@arm.com>
Commit b67bfe0d42ca ("hlist: drop the node parameter from iterators")
incorrectly changed the way that hlist iterators are used.
This patch fixes util/init.c so it passes parameters to the new
iterators in the right manner.
Cc: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
tools/kvm/util/init.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/kvm/util/init.c b/tools/kvm/util/init.c
index 33a5952..d4ce144 100644
--- a/tools/kvm/util/init.c
+++ b/tools/kvm/util/init.c
@@ -33,11 +33,10 @@ int init_list__init(struct kvm *kvm)
{
unsigned int i;
int r = 0;
- struct hlist_node *n;
struct init_item *t;
for (i = 0; i < ARRAY_SIZE(init_lists); i++)
- hlist_for_each_entry(t, n, &init_lists[i], n) {
+ hlist_for_each_entry(t, &init_lists[i], n) {
r = t->init(kvm);
if (r < 0) {
pr_warning("Failed init: %s\n", t->fn_name);
@@ -53,11 +52,10 @@ int init_list__exit(struct kvm *kvm)
{
int i;
int r = 0;
- struct hlist_node *n;
struct init_item *t;
for (i = ARRAY_SIZE(exit_lists) - 1; i >= 0; i--)
- hlist_for_each_entry(t, n, &exit_lists[i], n) {
+ hlist_for_each_entry(t, &exit_lists[i], n) {
r = t->init(kvm);
if (r < 0) {
pr_warning("%s failed.\n", t->fn_name);
--
1.8.0
next reply other threads:[~2013-03-04 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 6:27 Will Deacon [this message]
2013-03-04 6:27 ` [PATCH 2/2] kvm tools: 9p: fix compilation broken by new stat structures Will Deacon
2013-03-04 15:33 ` [PATCH 1/2] kvm tools: init: fix usage of hlist iterators Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362378451-15216-1-git-send-email-will.deacon@arm.com \
--to=will.deacon@arm.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=marc.zyngier@arm.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.