From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH 01/10] dmatest: cancel thread immediately when asked for
Date: Mon, 4 Mar 2013 11:09:25 +0200 [thread overview]
Message-ID: <1362388174-3435-2-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1362388174-3435-1-git-send-email-andriy.shevchenko@linux.intel.com>
If user have the timeout alike issues and wants to cancel the thread
immediately, the current call of wait_event_freezable_timeout is preventing to
this until timeout is expired. Thus, user will experience the unnecessary
delays.
Adding kthread_should_stop() check inside wait_event_freezable_timeout() solves
that.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/dmatest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index a2c8904..e6b4cfa 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -454,7 +454,8 @@ static int dmatest_func(void *data)
}
dma_async_issue_pending(chan);
- wait_event_freezable_timeout(done_wait, done.done,
+ wait_event_freezable_timeout(done_wait,
+ done.done || kthread_should_stop(),
msecs_to_jiffies(timeout));
status = dma_async_is_tx_complete(chan, cookie, NULL, NULL);
--
1.8.2.rc0.22.gb3600c3
next prev parent reply other threads:[~2013-03-04 9:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 9:09 [PATCH 00/10] dmatest: update the module to use debugfs Andy Shevchenko
2013-03-04 9:09 ` Andy Shevchenko [this message]
2013-03-05 1:41 ` [PATCH 01/10] dmatest: cancel thread immediately when asked for Viresh Kumar
2013-03-04 9:09 ` [PATCH 02/10] dmatest: allocate memory for pq_coefs from heap Andy Shevchenko
2013-03-05 1:43 ` Viresh Kumar
2013-03-04 9:09 ` [PATCH 03/10] dmatest: create dmatest_info to keep test parameters Andy Shevchenko
2013-03-05 1:47 ` Viresh Kumar
2013-03-04 9:09 ` [PATCH 04/10] dmatest: move dmatest_channels and nr_channels to dmatest_info Andy Shevchenko
2013-03-05 9:03 ` Vinod Koul
2013-03-05 9:12 ` Viresh Kumar
2013-03-05 9:19 ` Andy Shevchenko
2013-03-04 9:09 ` [PATCH 05/10] dmatest: split test parameters to separate structure Andy Shevchenko
2013-03-05 9:16 ` Viresh Kumar
2013-03-08 13:07 ` Andy Shevchenko
2013-03-04 9:09 ` [PATCH 06/10] dmatest: run test via debugfs Andy Shevchenko
2013-03-05 9:26 ` Vinod Koul
2013-03-05 10:36 ` Andy Shevchenko
2013-03-05 10:35 ` Vinod Koul
[not found] ` <CAHp75Vc6KmPQYjSx5m+gEBCe4g2tRgEPKyg4hZx9ytk99pB7Qw@mail.gmail.com>
[not found] ` <20130307061143.GD13370@intel.com>
2013-03-07 8:37 ` Andy Shevchenko
2013-03-04 9:09 ` [PATCH 07/10] dmatest: return actual state in 'run' file Andy Shevchenko
2013-03-04 9:09 ` [PATCH 08/10] dmatest: define MAX_ERROR_COUNT constant Andy Shevchenko
2013-03-04 9:09 ` [PATCH 09/10] dmatest: gather test results in the linked list Andy Shevchenko
2013-11-05 19:58 ` Dan Williams
2013-11-06 14:13 ` Andy Shevchenko
2013-11-06 18:11 ` Dan Williams
2013-11-07 14:37 ` Andy Shevchenko
2013-03-04 9:09 ` [PATCH 10/10] dmatest: append verify result to results Andy Shevchenko
2013-03-07 6:20 ` [PATCH 00/10] dmatest: update the module to use debugfs Vinod Koul
2013-03-08 13:11 ` Andy Shevchenko
2013-03-10 13:44 ` Viresh Kumar
2013-03-11 8:12 ` Andy Shevchenko
2013-03-21 5:11 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362388174-3435-2-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.