From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Brian Norris" <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org,
"David Woodhouse" <dwmw2@infradead.org>,
"Artem Bityutskiy" <artem.bityutskiy@linux.intel.com>
Subject: Re[2]: [PATCH 1/3] mtd: nand_base: Removed unnecessary command masking
Date: Tue, 05 Mar 2013 10:16:39 +0400 [thread overview]
Message-ID: <1362464199.278385277@f303.mail.ru> (raw)
In-Reply-To: <CAN8TOE9Q6udV2JTUDZbH7mMnz8c1HiYA--xBhQ79h4b2fhbtAw@mail.gmail.com>
> On Thu, Feb 28, 2013 at 12:02 AM, Alexander Shiyan <shc_work@mail.ru> wrote:
> > NAND command, passed to cmd_ctrl(), is masked with 0xff. This patch
> > removes this since masking is not necessary and masking is not performed
> > in other places for same call.
>
> As I commented on the other thread, this is not a sufficient
> explanation. AG-AND (soon to be removed) may use a fake 9-bit command
> which could expect this masking, even though masking is not done
> everywhere. Please document why the command does not need to be
> masked.
I think the best if Artem take this part into his patch.
And what about [3/3] part?
---
next prev parent reply other threads:[~2013-03-05 6:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 8:02 [PATCH 1/3] mtd: nand_base: Removed unnecessary command masking Alexander Shiyan
2013-02-28 8:02 ` [PATCH 2/3] mtd: nand_base: Removed unnecessary cleaning "onfi_version" variable Alexander Shiyan
2013-03-04 5:23 ` Brian Norris
2013-02-28 8:02 ` [PATCH 3/3] mtd: nand_base: Use readsb/readsw/writesb/writesw if possible Alexander Shiyan
2013-03-05 7:33 ` Brian Norris
2013-03-05 7:54 ` Re[2]: " Alexander Shiyan
2013-03-04 20:26 ` [PATCH 1/3] mtd: nand_base: Removed unnecessary command masking Brian Norris
2013-03-05 6:16 ` Alexander Shiyan [this message]
2013-03-11 8:10 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362464199.278385277@f303.mail.ru \
--to=shc_work@mail.ru \
--cc=artem.bityutskiy@linux.intel.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.