From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>,
Mike Dunn <mikedunn@newsguy.com>,
MTD Maling List <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 01/12] mtd: nand_ids: minor clean-ups
Date: Tue, 05 Mar 2013 10:32:11 +0200 [thread overview]
Message-ID: <1362472331.2943.25.camel@sauron> (raw)
In-Reply-To: <CAN8TOE-bJxgJ3HJCWyqkRJuOGjtoq0sLMNsDeFmZLAoB+Qg0bg@mail.gmail.com>
On Mon, 2013-03-04 at 10:36 -0800, Brian Norris wrote:
> > + * These are the new chips with large page size, page size and
> > + * eraseblock size is determined from the extended id bytes.
>
> This is also incorrect grammar. It uses a comma to divide sentences
> and also uses "is". I would write something like this:
>
> "These are the new chips with large page size. Their page size and
> eraseblock size are determined from the extended ID bytes."
Thanks Brian, will fix.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-03-05 8:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 16:42 [PATCH 00/12] mtd: nand: provision full ID support Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 01/12] mtd: nand_ids: minor clean-ups Artem Bityutskiy
2013-03-04 18:36 ` Brian Norris
2013-03-05 8:32 ` Artem Bityutskiy [this message]
2013-03-04 16:42 ` [PATCH 02/12] mtd: remove museum NAND ID's support Artem Bityutskiy
2013-03-04 18:37 ` Brian Norris
2013-03-05 6:23 ` Re[2]: " Alexander Shiyan
2013-03-04 16:42 ` [PATCH 03/12] arm: defconfigs: lpc32xx_defconfig: remove museum NAND option Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 04/12] mtd: nand: remove the rtc_from4 driver support Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 05/12] mtd: nand: remove AG-AND support Artem Bityutskiy
2013-03-04 18:56 ` Brian Norris
2013-03-05 8:37 ` Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 06/12] mtd: nand: remove a bunch of unused commands Artem Bityutskiy
2013-03-04 19:04 ` Brian Norris
2013-03-04 19:29 ` Re[2]: " Alexander Shiyan
2013-03-04 19:54 ` Brian Norris
2013-03-04 20:03 ` Re[4]: " Alexander Shiyan
2013-03-04 20:27 ` Brian Norris
2013-03-04 16:42 ` [PATCH 07/12] mtd: nand: remove NAND_NO_PADDING macro Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 08/12] mtd: nand: remove NAND_COPYBACK macro Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 09/12] mtd: nand: use NAND_HAS_CACHEPROG Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 10/12] mtd: nand_ids: introduce helper macros Artem Bityutskiy
2013-03-04 19:23 ` Brian Norris
2013-03-05 13:34 ` Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 11/12] mtd: nand: rename the id filed of 'struct nand_flash_dev' Artem Bityutskiy
2013-03-04 18:29 ` Brian Norris
2013-03-04 16:42 ` [PATCH 12/12] mtd: nand: provision full ID support Artem Bityutskiy
2013-03-04 16:50 ` Jan Lübbe
2013-03-04 19:45 ` Brian Norris
2013-03-05 10:37 ` Artem Bityutskiy
2013-03-06 5:32 ` Huang Shijie
2013-03-05 6:08 ` Huang Shijie
2013-03-05 10:42 ` Artem Bityutskiy
2013-03-05 14:36 ` Huang Shijie
2013-03-05 14:55 ` Artem Bityutskiy
2013-03-06 2:17 ` Huang Shijie
2013-03-04 19:48 ` [PATCH 00/12] " Brian Norris
2013-03-06 7:19 ` Artem Bityutskiy
2013-03-06 7:42 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362472331.2943.25.camel@sauron \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.