All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>,
	MTD Maling List <linux-mtd@lists.infradead.org>
Subject: [PATCH 01/11] mtd: nand_ids: minor clean-ups
Date: Tue,  5 Mar 2013 15:17:14 +0200	[thread overview]
Message-ID: <1362489444-27762-2-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1362489444-27762-1-git-send-email-dedekind1@gmail.com>

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Clean-up the code a little bit:
  * clean-up commentaries.
  * move macro definitions to the top of the file.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 drivers/mtd/nand/nand_ids.c |   30 +++++++++++++-----------------
 1 file changed, 13 insertions(+), 17 deletions(-)

diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
index e3aa274..f1a799c 100644
--- a/drivers/mtd/nand/nand_ids.c
+++ b/drivers/mtd/nand/nand_ids.c
@@ -10,17 +10,17 @@
  */
 #include <linux/module.h>
 #include <linux/mtd/nand.h>
+
+#define LP_OPTIONS NAND_SAMSUNG_LP_OPTIONS
+#define LP_OPTIONS16 (LP_OPTIONS | NAND_BUSWIDTH_16)
+
 /*
-*	Chip ID list
-*
-*	Name. ID code, pagesize, chipsize in MegaByte, eraseblock size,
-*	options
-*
-*	Pagesize; 0, 256, 512
-*	0	get this information from the extended chip ID
-+	256	256 Byte page size
-*	512	512 Byte page size
-*/
+ * The chip ID list:
+ *    name, device ID, page size, chip size in MiB, eraseblock size, options
+ *
+ * If page size and eraseblock size are 0, the sizes are taken from the
+ * extended chip ID.
+ */
 struct nand_flash_dev nand_flash_ids[] = {
 
 #ifdef CONFIG_MTD_NAND_MUSEUM_IDS
@@ -67,11 +67,9 @@ struct nand_flash_dev nand_flash_ids[] = {
 	{"NAND 256MiB 3,3V 8-bit",	0x71, 512, 256, 0x4000, 0},
 
 	/*
-	 * These are the new chips with large page size. The pagesize and the
-	 * erasesize is determined from the extended id bytes
+	 * These are the new chips with large page size. Their page size and
+	 * eraseblock size are determined from the extended ID bytes.
 	 */
-#define LP_OPTIONS NAND_SAMSUNG_LP_OPTIONS
-#define LP_OPTIONS16 (LP_OPTIONS | NAND_BUSWIDTH_16)
 
 	/* 512 Megabit */
 	{"NAND 64MiB 1,8V 8-bit",	0xA2, 0,  64, 0, LP_OPTIONS},
@@ -162,9 +160,7 @@ struct nand_flash_dev nand_flash_ids[] = {
 	{NULL,}
 };
 
-/*
-*	Manufacturer ID list
-*/
+/* Manufacturer IDs */
 struct nand_manufacturers nand_manuf_ids[] = {
 	{NAND_MFR_TOSHIBA, "Toshiba"},
 	{NAND_MFR_SAMSUNG, "Samsung"},
-- 
1.7.10.4

  reply	other threads:[~2013-03-05 13:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05 13:17 [PATCH 00/11] mtd: removals and simplifications Artem Bityutskiy
2013-03-05 13:17 ` Artem Bityutskiy [this message]
2013-03-05 13:17 ` [PATCH 02/11] mtd: decommission the NAND museum Artem Bityutskiy
2013-03-06  7:32   ` Brian Norris
2013-03-06  7:44     ` Artem Bityutskiy
2013-03-06  8:17     ` Artem Bityutskiy
2013-03-05 13:17 ` [PATCH 03/11] arm: defconfigs: lpc32xx_defconfig: remove the museum NAND option Artem Bityutskiy
2013-03-06  8:49   ` Artem Bityutskiy
2013-03-06  9:04     ` Roland Stigge
2013-03-06  9:19       ` Artem Bityutskiy
2013-03-05 13:17 ` [PATCH 04/11] mtd: nand: remove the rtc_from4 driver support Artem Bityutskiy
2013-03-05 13:17 ` [PATCH 05/11] mtd: nand: remove AG-AND support Artem Bityutskiy
2013-03-05 13:17 ` [PATCH 06/11] mtd: nand: remove a bunch of unused commands Artem Bityutskiy
2013-03-05 13:17 ` [PATCH 07/11] mtd: nand: remove NAND_NO_PADDING macro Artem Bityutskiy
2013-03-05 13:17 ` [PATCH 08/11] mtd: nand: remove NAND_COPYBACK macro Artem Bityutskiy
2013-03-05 13:17 ` [PATCH 09/11] mtd: nand: use NAND_HAS_CACHEPROG Artem Bityutskiy
2013-03-05 13:17 ` [PATCH 10/11] mtd: nand: rename the id field of 'struct nand_flash_dev' Artem Bityutskiy
2013-03-05 13:17 ` [PATCH 11/11] mtd: nand: remove few tiny page NAND bits Artem Bityutskiy
2013-03-06  7:11 ` [PATCH 00/11] mtd: removals and simplifications Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362489444-27762-2-git-send-email-dedekind1@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.