Re: [PATCH] siggen: add quotes around variable values to see whitespace

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2013-03-04 at 19:24 +0100, Martin Jansa wrote:
> On Mon, Mar 04, 2013 at 09:49:06AM -0600, Mark Hatle wrote:
> > On 3/2/13 10:50 AM, Martin Jansa wrote:
> > > * without this change it's hard to see what's changed:
> > >    bitbake-diffsigs sstate-cache/*/sstate-depmodwrapper-cross-cortexa8-vfp-neon-oe-linux-gnueabi-1.0-r0-cortexa8-vfp-neon-*_populate-sysroot.tgz.siginfo
> > >    basehash changed from 62f28c13172d38af917716d6d4b15ac5 to 9cf38842bcc79e0a4356856a64141548
> > >    Variable TUNE_CCARGS value changed from  -march=armv7-a    -mthumb -mthumb-interwork -mfloat-abi=softfp -mfpu=neon -mtune=cortex-a8  to  -march=armv7-a    -mthumb -mthumb-interwork -mfloat-abi=softfp -mfpu=neon -mtune=cortex-a8
> > >    Hash for dependent task depmodwrapper-cross_1.0.bb.do_install changed from 4494cb6c117309a9b4c541ad86c0aac5 to 1e3bcf2d14e5bd30a38350b41bb98db3
> > >
> > > * with this change, we can see extra trailing space in first version:
> > >    basehash changed from 62f28c13172d38af917716d6d4b15ac5 to 9cf38842bcc79e0a4356856a64141548
> > >    Variable TUNE_CCARGS value changed from ' -march=armv7-a    -mthumb -mthumb-interwork -mfloat-abi=softfp -mfpu=neon -mtune=cortex-a8 ' to ' -march=armv7-a    -mthumb -mthumb-interwork -mfloat-abi=softfp -mfpu=neon -mtune=cortex-a8'
> > >    Hash for dependent task depmodwrapper-cross_1.0.bb.do_install changed from 4494cb6c117309a9b4c541ad86c0aac5 to 1e3bcf2d14e5bd30a38350b41bb98db3
> > 
> > No objection to this patch, but it does raise the question.  Should we somehow 
> > strip the leading and training white space, maybe even multiple spaces (like 
> > above) and then use the results to generate the checksum?
> > 
> > If I saw the above, my first comment would be "well that's stupid, the output is 
> > the same"..  (Of course performance might be impacted by all of that stripping..)
> 
> I had the same comment when I've seen it, that's why I added those
> quotes to be able to spot that space at all.
> 
> I'm not sure what caused that extra space and so many rebuilds, but I've
> noticed it today in completely different build where space in multiline
> variable were squashed to one space separator and I think the only
> difference were pool patches in bitbake.

The pool patches shouldn't make any difference to this so this is rather
bizarre. Do you have anything you can reproduce at will (ignoring the
pool patches since they've been reverted for other reasons now).

Cheers,

Richard