Re: [PATCH 4 of 5 v3] xen: tracing: introduce per-scheduler trace event IDs

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1514 bytes --]

On ven, 2013-03-08 at 16:08 +0000, George Dunlap wrote:
> On Mon, Dec 17, 2012 at 10:29 PM, Dario Faggioli
> > This also converts the existing credit2 tracing (the only scheduler
> > generating tracing events up to now) to the new system.
> 
> Dario, do you have xenalyze patches for this changeset somewhere?
> 
TBH, I haven't done any xenalyze modification, corresponding to this.
However, I'm not really sure it's necessary.

Well, let me put it this way, I run xenalyze on traces collected with
this change, and everything works, and the scheduler-id is shown in the
event. OF course we could improve the situation by decoding it in
xenalyze and showing it explicitly in the trace analysis. I (if this is
what you were referring to) agree it would be nice, but again, it's not
something I've done yet, and not something I can commit on doing in the
next days either. :-(

I don't think it's terrible, as the change only affect traces where the
actual event is also reported encoded, so you have to go check the
headers (or remember stuff) anyway. Again, I completely agree it would
be nice to limit the amount of stuff one has to remember, and I'm up for
it, just not immediately... Is that fine/enough?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel