From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCHv3] perf: Fix vmalloc ring buffer free function
Date: Tue, 12 Mar 2013 16:26:12 +0100 [thread overview]
Message-ID: <1363101972.24558.3.camel@laptop> (raw)
In-Reply-To: <20130312135219.GA32001@krava.brq.redhat.com>
On Tue, 2013-03-12 at 14:52 +0100, Jiri Olsa wrote:
> > @@ -373,7 +373,7 @@ struct ring_buffer *rb_alloc(int nr_pages, long watermark, int cpu, int flags)
> > rb->user_page = all_buf;
> > rb->data_pages[0] = all_buf + PAGE_SIZE;
> > rb->page_order = ilog2(nr_pages);
> > - rb->nr_pages = 1;
> > + rb->nr_pages = nr_pages;
> >
>
> hum, and this ^^^ breaks perf_data_size(rb) ;)
>
> static inline unsigned long perf_data_size(struct ring_buffer *rb)
> {
> return rb->nr_pages << (PAGE_SHIFT + page_order(rb));
> }
How so? 0 << n keeps being 0, right?
next prev parent reply other threads:[~2013-03-12 15:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 16:34 [PATCHv2] perf: Fix vmalloc ring buffer free function Jiri Olsa
2013-03-06 14:30 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2013-03-06 15:20 ` [PATCHv2] " Frederic Weisbecker
2013-03-06 15:37 ` Jiri Olsa
2013-03-06 15:40 ` Frederic Weisbecker
2013-03-11 9:40 ` Peter Zijlstra
2013-03-11 11:21 ` Jiri Olsa
2013-03-11 12:15 ` Ingo Molnar
2013-03-11 16:26 ` Peter Zijlstra
2013-03-11 16:43 ` Jiri Olsa
2013-03-11 17:44 ` Peter Zijlstra
2013-03-11 18:02 ` Jiri Olsa
2013-03-12 10:05 ` [PATCHv3] " Jiri Olsa
2013-03-12 10:27 ` Peter Zijlstra
2013-03-12 10:53 ` Jiri Olsa
2013-03-12 12:38 ` Peter Zijlstra
2013-03-12 13:52 ` Jiri Olsa
2013-03-12 15:26 ` Peter Zijlstra [this message]
2013-03-12 15:36 ` Jiri Olsa
2013-03-12 16:24 ` Peter Zijlstra
2013-03-12 17:04 ` Jiri Olsa
2013-03-13 11:15 ` Jiri Olsa
2013-03-18 19:05 ` Jiri Olsa
2013-03-19 11:46 ` Peter Zijlstra
2013-03-19 14:35 ` [PATCHv4] perf: Fix vmalloc ring buffer pages handling Jiri Olsa
2013-04-30 15:36 ` Jiri Olsa
2013-05-01 10:34 ` Ingo Molnar
2013-05-02 7:54 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363101972.24558.3.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.