All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qingtang Zhou <zhouqt@gmail.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Qingtang Zhou <zhouqt@gmail.com>,
	Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH] configure: Print out missing library when configure fails
Date: Fri, 15 Mar 2013 19:46:16 +0800	[thread overview]
Message-ID: <1363347976-18263-1-git-send-email-zhouqt@gmail.com> (raw)

This patch let configure tool print out which library
is missing besides the qemu feature name when it fails.

CC: Blue Swirl <blauwirbel@gmail.com>
CC: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Qingtang Zhou <zhouqt@gmail.com>
---
 configure | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index 46a7594..ca6258d 100755
--- a/configure
+++ b/configure
@@ -1352,9 +1352,14 @@ esac
 
 feature_not_found() {
   feature=$1
+  shift
+  missing_lib=$*
 
   echo "ERROR"
   echo "ERROR: User requested feature $feature"
+  if [ "$missing_lib" != "" ]; then
+      echo "ERROR: This feature needs $missing_lib library"
+  fi
   echo "ERROR: configure was not able to find it"
   echo "ERROR"
   exit 1;
@@ -1677,7 +1682,7 @@ if test "$gtk" != "no"; then
 	gtk="yes"
     else
 	if test "$gtk" = "yes" ; then
-	    feature_not_found "gtk"
+	    feature_not_found "gtk" "$gtkpackage-$gtkversion" "$vtepackage-$vteversion"
 	fi
 	gtk="no"
     fi
@@ -2472,7 +2477,7 @@ EOF
     libs_softmmu="$glusterfs_libs $libs_softmmu"
   else
     if test "$glusterfs" = "yes" ; then
-      feature_not_found "GlusterFS backend support"
+      feature_not_found "GlusterFS backend support" "gfapi" "gfrpc" "gfxdr"
     fi
     glusterfs=no
   fi
@@ -2784,7 +2789,7 @@ if test "$docs" != "no" ; then
     docs=yes
   else
     if test "$docs" = "yes" ; then
-      feature_not_found "docs"
+      feature_not_found "docs" "makeinfo" "pod2man"
     fi
     docs=no
   fi
@@ -2905,7 +2910,7 @@ EOF
     spice_server_version=$($pkg_config --modversion spice-server)
   else
     if test "$spice" = "yes" ; then
-      feature_not_found "spice"
+      feature_not_found "spice" "spice-protocol" "spice-server"
     fi
     spice="no"
   fi
@@ -2955,7 +2960,7 @@ if test "$usb_redir" != "no" ; then
         libs_softmmu="$libs_softmmu $usb_redir_libs"
     else
         if test "$usb_redir" = "yes"; then
-            feature_not_found "usb-redir"
+            feature_not_found "usb-redir" "libusbredirparser-0.5"
         fi
         usb_redir="no"
     fi
-- 
1.8.1.4

             reply	other threads:[~2013-03-15 11:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 11:46 Qingtang Zhou [this message]
2013-03-15 11:53 ` [Qemu-devel] [PATCH] configure: Print out missing library when configure fails Peter Maydell
2013-03-15 15:10   ` Qingtang Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363347976-18263-1-git-send-email-zhouqt@gmail.com \
    --to=zhouqt@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.