From: Johannes Berg <johannes@sipsolutions.net>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Wang Dongsheng <dongsheng.wang@freescale.com>
Subject: Re: [PATCH] powerpc: add Book E support to 64-bit hibernation
Date: Fri, 15 Mar 2013 16:22:06 +0100 [thread overview]
Message-ID: <1363360926.8656.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1363279961.28440.4@snotra>
On Thu, 2013-03-14 at 11:52 -0500, Scott Wood wrote:
> > > +#ifdef CONFIG_PPC_BOOK3S_64
> > > /* can't use RESTORE_SPECIAL(MSR) */
> > > ld r0, SL_MSR(r11)
> > > mtmsrd r0, 0
> >
> > Unfortunately, I forgot the reason for this comment, and didn't put a
> > better one (almost 6 years ago!!)
> If it's because book3s needs mtmsrd instead of mtmsr, that doesn't
> apply to booke.
Indeed, looking at the code again now that seems pretty obvious.
Looking at the patch again, I'd be a little concerned about the lack of
cache flushing, seems a bit odd but I'm sure you know what you're doing
(and I don't know book3e at all, and hardly remember book3s -- or even
that name...) :-)
johannes
next prev parent reply other threads:[~2013-03-16 12:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 3:36 [PATCH] powerpc: add Book E support to 64-bit hibernation Wang Dongsheng
2013-03-14 8:37 ` Johannes Berg
2013-03-14 16:52 ` Scott Wood
2013-03-15 15:22 ` Johannes Berg [this message]
2013-03-18 22:12 ` Scott Wood
2013-03-19 20:55 ` Johannes Berg
2013-03-19 21:10 ` Scott Wood
2013-03-19 21:22 ` Johannes Berg
2013-03-19 22:16 ` Scott Wood
2013-03-22 10:58 ` Johannes Berg
2013-03-22 22:14 ` Scott Wood
2013-04-02 5:28 ` Wang Dongsheng-B40534
2013-04-03 0:34 ` Scott Wood
2013-04-03 5:36 ` Wang Dongsheng-B40534
2013-04-03 20:15 ` Scott Wood
2013-04-07 3:01 ` Wang Dongsheng-B40534
2013-04-08 18:24 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363360926.8656.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dongsheng.wang@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.