Re: [Qemu-devel] [PATCH] libcacard/vscclient: fix leakage of socket on error paths

[Alon Levy <alevy@redhat.com>]

> Spotted by Coverity.
> 

Self NACK.

I'll send a more complete patch, and use closesocket.

> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>  libcacard/vscclient.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
> index ac23647..9fcc548 100644
> --- a/libcacard/vscclient.c
> +++ b/libcacard/vscclient.c
> @@ -618,18 +618,22 @@ connect_to_qemu(
>      if (ret != 0) {
>          /* Error */
>          fprintf(stderr, "getaddrinfo failed\n");
> -        return -1;
> +        goto cleanup_socket;
>      }
>  
>      if (connect(sock, server->ai_addr, server->ai_addrlen) < 0) {
>          /* Error */
>          fprintf(stderr, "Could not connect\n");
> -        return -1;
> +        goto cleanup_socket;
>      }
>      if (verbose) {
>          printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader));
>      }
>      return sock;
> +
> +cleanup_socket:
> +    close(sock);
> +    return -1;
>  }
>  
>  int
> --
> 1.8.2.1
> 
> 
>