From: Shuah Khan <shuah.khan@hp.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: linux-kernel@vger.kernel.org, konrad.wilk@oracle.com,
joerg.roedel@amd.com, konrad@kernel.org,
christoph.paasch@uclouvain.be, mingo@redhat.com, hpa@zytor.com,
akpm@linux-foundation.org, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com, shuah.khan@hp.com
Subject: Re: [PATCH 1/2] dma-debug: Fix locking bug in check_unmap
Date: Tue, 19 Mar 2013 14:29:07 -0600 [thread overview]
Message-ID: <1363724947.4519.9.camel@lorien2> (raw)
In-Reply-To: <20130318221243.7349.64147.stgit@ahduyck-cp1.jf.intel.com>
On Mon, 2013-03-18 at 15:12 -0700, Alexander Duyck wrote:
> In check_unmap it is possible to get into a dead-locked state if
> dma_mapping_error is called. The problem is that the bucket is locked in
> check_unmap, and locked again by debug_dma_mapping_error which is called by
> dma_mapping_error. To resolve that we must release the lock on the bucket
> before making the call to dma_mapping_error.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Looks good.
Reviewed-by: Shuah Khan
Tested-by Shuah Khan
Thanks for finding and fixing the problem.
-- Shuah
next prev parent reply other threads:[~2013-03-19 20:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 9:31 igb_poll - device driver failed to check map error Christoph Paasch
2013-03-13 15:30 ` Wyborny, Carolyn
2013-03-15 2:18 ` Alexander Duyck
2013-03-15 7:52 ` Christoph Paasch
2013-03-15 16:03 ` Allan, Bruce W
2013-03-16 9:27 ` Christoph Paasch
2013-03-15 16:07 ` Alexander Duyck
2013-03-15 23:08 ` Alexander Duyck
2013-03-16 11:07 ` Christoph Paasch
2013-03-18 17:29 ` Alexander Duyck
2013-03-18 22:12 ` [PATCH 0/2] Address issues in dma-debug API Alexander Duyck
2013-03-18 22:12 ` [PATCH 1/2] dma-debug: Fix locking bug in check_unmap Alexander Duyck
2013-03-19 20:29 ` Shuah Khan [this message]
2013-03-18 22:12 ` [PATCH 2/2] dma-debug: Update DMA debug API to better handle multiple mappings of a buffer Alexander Duyck
2013-03-19 20:30 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363724947.4519.9.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=christoph.paasch@uclouvain.be \
--cc=hpa@zytor.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joerg.roedel@amd.com \
--cc=konrad.wilk@oracle.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.