From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: [PATCH] irqchip: gic: fix irq_trigger return Date: Tue, 19 Mar 2013 16:05:49 -0700 Message-ID: <1363734349-32635-1-git-send-email-sboyd@codeaurora.org> Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:27221 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756401Ab3CSXFv (ORCPT ); Tue, 19 Mar 2013 19:05:51 -0400 Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Thomas Gleixner Cc: Abhijeet Dharmapurikar , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Abhijeet Dharmapurikar The genirq layer expects a 0 in case of failure but the code is returning -ENXIO. Fix it. Signed-off-by: Abhijeet Dharmapurikar Signed-off-by: Stephen Boyd --- drivers/irqchip/irq-gic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 644d724..2ebf28a 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d) if (gic_arch_extn.irq_retrigger) return gic_arch_extn.irq_retrigger(d); - return -ENXIO; + /* the genirq layer expects 0 for a failure */ + return 0; } #ifdef CONFIG_SMP -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Tue, 19 Mar 2013 16:05:49 -0700 Subject: [PATCH] irqchip: gic: fix irq_trigger return Message-ID: <1363734349-32635-1-git-send-email-sboyd@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Abhijeet Dharmapurikar The genirq layer expects a 0 in case of failure but the code is returning -ENXIO. Fix it. Signed-off-by: Abhijeet Dharmapurikar Signed-off-by: Stephen Boyd --- drivers/irqchip/irq-gic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 644d724..2ebf28a 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -236,7 +236,8 @@ static int gic_retrigger(struct irq_data *d) if (gic_arch_extn.irq_retrigger) return gic_arch_extn.irq_retrigger(d); - return -ENXIO; + /* the genirq layer expects 0 for a failure */ + return 0; } #ifdef CONFIG_SMP -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation