From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 10/13] drm/i915: check panel fit status at update_plane time Date: Wed, 20 Mar 2013 14:46:09 +0200 Message-ID: <1363783569.13528.31.camel@intelbox> References: <1361309508-4901-1-git-send-email-jbarnes@virtuousgeek.org> <1361309508-4901-11-git-send-email-jbarnes@virtuousgeek.org> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 06E54E5DB2 for ; Wed, 20 Mar 2013 05:46:11 -0700 (PDT) In-Reply-To: <1361309508-4901-11-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 2013-02-19 at 13:31 -0800, Jesse Barnes wrote: > We may need to disable the panel when flipping to a new buffer, so check > the state here and zero it out if needed, otherwise leave it alone. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 595590c..91660b1 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -2304,6 +2304,25 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y, > if (crtc->fb) > intel_finish_fb(crtc->fb); > > + I915_WRITE(PIPESRC(intel_crtc->pipe), > + ((crtc->mode.hdisplay - 1) << 16) | > + (crtc->mode.vdisplay - 1)); > + if (!dev_priv->pch_pf_size && > + (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) || > + intel_pipe_has_type(crtc, INTEL_OUTPUT_EDP))) { > + /* Force use of hard-coded filter coefficients > + * as some pre-programmed values are broken, > + * e.g. x201. > + */ Nitpick: multiline comments should start with an empty /* line. > + if (IS_IVYBRIDGE(dev)) > + I915_WRITE(PF_CTL(intel_crtc->pipe), 0); > + else > + I915_WRITE(PF_CTL(intel_crtc->pipe), 0); No difference in the branches? > + I915_WRITE(PF_WIN_POS(intel_crtc->pipe), 0); > + I915_WRITE(PF_WIN_SZ(intel_crtc->pipe), 0); > + } > + > + > ret = dev_priv->display.update_plane(crtc, fb, x, y); > if (ret) { > intel_unpin_fb_obj(to_intel_framebuffer(fb)->obj);