From: Scott Wood <scottwood@freescale.com>
To: Kevin Hilman <khilman@linaro.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
<linaro-kernel@lists.linaro.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>,
"open list:KERNEL VIRTUAL MA..." <kvm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: allow host header to be included even for !CONFIG_KVM
Date: Wed, 20 Mar 2013 18:58:41 -0500 [thread overview]
Message-ID: <1363823921.25034.35@snotra> (raw)
In-Reply-To: <1363306426-27209-1-git-send-email-khilman@linaro.org> (from khilman@linaro.org on Thu Mar 14 19:13:46 2013)
On 03/14/2013 07:13:46 PM, Kevin Hilman wrote:
> The new context tracking subsystem unconditionally includes kvm_host.h
> headers for the guest enter/exit macros. This causes a compile
> failure when KVM is not enabled.
>
> Fix by adding an IS_ENABLED(CONFIG_KVM) check to kvm_host so it can
> be included/compiled even when KVM is not enabled.
>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> Applies on v3.9-rc2
>
> include/linux/kvm_host.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
This broke the PPC non-KVM build, which was relying on stub functions
in kvm_ppc.h, which relies on "struct vcpu" in kvm_host.h.
Why can't the entirety kvm_host.h be included regardless of CONFIG_KVM,
just like most other feature-specific headers? Why can't the if/else
just go around the functions that you want to stub out for non-KVM
builds?
-Scott
next prev parent reply other threads:[~2013-03-20 23:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 0:13 [PATCH] KVM: allow host header to be included even for !CONFIG_KVM Kevin Hilman
2013-03-18 21:04 ` Marcelo Tosatti
2013-03-20 23:58 ` Scott Wood [this message]
2013-03-21 7:29 ` Gleb Natapov
2013-03-21 14:27 ` Kevin Hilman
2013-03-21 18:42 ` Scott Wood
2013-03-21 19:16 ` Gleb Natapov
2013-03-21 19:33 ` Scott Wood
2013-03-21 21:17 ` Gleb Natapov
2013-03-22 0:02 ` Kevin Hilman
2013-03-24 10:21 ` Gleb Natapov
2013-03-24 13:44 ` Frederic Weisbecker
2013-03-24 14:01 ` Gleb Natapov
2013-03-25 21:14 ` Kevin Hilman
2013-04-02 11:56 ` Gleb Natapov
2013-05-02 21:58 ` Alexander Graf
2013-05-15 22:52 ` Frederic Weisbecker
2013-05-17 1:04 ` Frederic Weisbecker
2013-05-17 14:09 ` Kevin Hilman
2013-05-17 14:34 ` Frederic Weisbecker
2013-05-17 17:00 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363823921.25034.35@snotra \
--to=scottwood@freescale.com \
--cc=fweisbec@gmail.com \
--cc=gleb@redhat.com \
--cc=khilman@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.