From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Nemesa Garg <nemesa.garg@intel.com>,
<intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 08/12] drm/i915/display: Compare the sharpness state
Date: Tue, 1 Apr 2025 11:04:41 +0530 [thread overview]
Message-ID: <13638c0a-7d2d-45a3-a110-5821096dee70@intel.com> (raw)
In-Reply-To: <20250321160628.2663912-9-nemesa.garg@intel.com>
On 3/21/2025 9:36 PM, Nemesa Garg wrote:
> Compare the sharpness win_size, strength and enable bits
>
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 4ffe738ad725..f807915e0fee 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -5276,6 +5276,9 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>
> PIPE_CONF_CHECK_I(scaler_state.scaler_id);
> PIPE_CONF_CHECK_I(pixel_rate);
> + PIPE_CONF_CHECK_BOOL(hw.casf_params.casf_enable);
> + PIPE_CONF_CHECK_I(hw.casf_params.win_size);
> + PIPE_CONF_CHECK_I(hw.casf_params.strength);
This can be clubbed with Patch#10 where we compute, and get the config
for CASF.
Regards,
Ankit
>
> PIPE_CONF_CHECK_X(gamma_mode);
> if (display->platform.cherryview)
next prev parent reply other threads:[~2025-04-01 5:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 16:06 [PATCH 00/12] Introduce drm sharpness property Nemesa Garg
2025-03-21 16:06 ` [PATCH 01/12] drm/i915/display: Introduce sharpness strength property Nemesa Garg
2025-03-21 16:06 ` [PATCH 02/12] drm/i915/display: Introduce HAS_CASF for sharpness support Nemesa Garg
2025-04-01 5:22 ` Nautiyal, Ankit K
2025-03-21 16:06 ` [PATCH 03/12] drm/i915/display: Add sharpness strength and winsize Nemesa Garg
2025-04-01 5:28 ` Nautiyal, Ankit K
2025-03-21 16:06 ` [PATCH 04/12] drm/i915/display: Add filter lut values Nemesa Garg
2025-03-21 16:06 ` [PATCH 05/12] drm/i915/display: Compute the scaler filter Nemesa Garg
2025-04-01 5:29 ` Nautiyal, Ankit K
2025-03-21 16:06 ` [PATCH 06/12] drm/i915/display: Add and compute scaler parameter Nemesa Garg
2025-03-21 16:06 ` [PATCH 07/12] drm/i915/display: Configure the second scaler for Nemesa Garg
2025-04-01 5:32 ` Nautiyal, Ankit K
2025-03-21 16:06 ` [PATCH 08/12] drm/i915/display: Compare the sharpness state Nemesa Garg
2025-04-01 5:34 ` Nautiyal, Ankit K [this message]
2025-03-21 16:06 ` [PATCH 09/12] drm/i915/display: Set a scaler mode Nemesa Garg
2025-04-01 5:37 ` Nautiyal, Ankit K
2025-04-01 5:54 ` Garg, Nemesa
2025-03-21 16:06 ` [PATCH 10/12] drm/i915/display: Write and read back the casf registers Nemesa Garg
2025-04-01 5:40 ` Nautiyal, Ankit K
2025-03-21 16:06 ` [PATCH 11/12] drm/i915/display: Enable/disable casf Nemesa Garg
2025-04-01 6:09 ` Nautiyal, Ankit K
2025-03-21 16:06 ` [PATCH 12/12] drm/i915/display: Expose sharpness strength property Nemesa Garg
2025-04-01 6:10 ` Nautiyal, Ankit K
2025-03-21 16:17 ` ✓ CI.Patch_applied: success for Introduce drm sharpness property (rev11) Patchwork
2025-03-21 16:17 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-21 16:19 ` ✓ CI.KUnit: success " Patchwork
2025-03-21 16:35 ` ✓ CI.Build: " Patchwork
2025-03-21 16:37 ` ✓ CI.Hooks: " Patchwork
2025-03-21 16:39 ` ✗ CI.checksparse: warning " Patchwork
2025-03-21 17:04 ` ✓ Xe.CI.BAT: success " Patchwork
2025-03-21 17:46 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2025-03-21 17:46 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-03-21 18:05 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-21 18:11 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-21 21:40 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13638c0a-7d2d-45a3-a110-5821096dee70@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=nemesa.garg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.