From: Cong Wang <amwang@redhat.com>
To: netdev@vger.kernel.org
Cc: Pravin B Shelar <pshelar@nicira.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Cong Wang <amwang@redhat.com>
Subject: [Patch net-next] ip_gre: increase inner ip header ID during segmentation
Date: Fri, 22 Mar 2013 15:50:00 +0800 [thread overview]
Message-ID: <1363938600-26129-1-git-send-email-amwang@redhat.com> (raw)
From: Cong Wang <amwang@redhat.com>
According to the previous discussion [1] on netdev list, DaveM insists
we should increase the IP header ID for each segmented packets.
This patch fixes it.
Cc: Pravin B Shelar <pshelar@nicira.com>
Cc: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
1. http://marc.info/?t=136384172700001&r=1&w=2
---
diff --git a/net/ipv4/gre.c b/net/ipv4/gre.c
index 7a4c710..3cf20a4 100644
--- a/net/ipv4/gre.c
+++ b/net/ipv4/gre.c
@@ -125,9 +125,11 @@ static struct sk_buff *gre_gso_segment(struct sk_buff *skb,
netdev_features_t enc_features;
int ghl = GRE_HEADER_SECTION;
struct gre_base_hdr *greh;
+ struct iphdr *iph;
int mac_len = skb->mac_len;
int tnl_hlen;
bool csum;
+ __be16 id;
if (unlikely(skb_shinfo(skb)->gso_type &
~(SKB_GSO_TCPV4 |
@@ -170,6 +172,8 @@ static struct sk_buff *gre_gso_segment(struct sk_buff *skb,
skb_set_network_header(skb, skb_inner_network_offset(skb));
skb->mac_len = skb_inner_network_offset(skb);
+ iph = (struct iphdr *)skb->data;
+ id = iph->id;
/* segment inner packet. */
enc_features = skb->dev->hw_enc_features & netif_skb_features(skb);
segs = skb_mac_gso_segment(skb, enc_features);
@@ -179,6 +183,8 @@ static struct sk_buff *gre_gso_segment(struct sk_buff *skb,
skb = segs;
tnl_hlen = skb_tnl_header_len(skb);
do {
+ iph = (struct iphdr *)skb->data;
+ iph->id = id++;
__skb_push(skb, ghl);
if (csum) {
__be32 *pcsum;
next reply other threads:[~2013-03-22 7:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 7:50 Cong Wang [this message]
2013-03-22 7:57 ` [Patch net-next] ip_gre: increase inner ip header ID during segmentation Cong Wang
2013-03-22 10:31 ` [PATCH net-next 1/2] " Cong Wang
2013-03-22 10:31 ` [PATCH net-next 2/2] udp: " Cong Wang
2013-03-22 14:24 ` David Miller
2013-03-22 14:24 ` [PATCH net-next 1/2] ip_gre: " David Miller
2013-03-22 17:12 ` Pravin Shelar
2013-03-23 3:25 ` Cong Wang
2013-03-23 5:14 ` [PATCH net-next] 8021q: fix a potential use-after-free Cong Wang
2013-03-23 5:14 ` [PATCH net-next] 802: fix a possible race condition Cong Wang
2013-03-24 21:24 ` David Miller
2013-03-25 13:32 ` Cong Wang
2013-03-25 14:08 ` Eric Dumazet
2013-03-26 3:01 ` Cong Wang
2013-03-23 15:16 ` [PATCH net-next] 8021q: fix a potential use-after-free Eric Dumazet
2013-03-24 21:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363938600-26129-1-git-send-email-amwang@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.