From: Thomas Meyer <thomas@m3y3r.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, x86@kernel.org
Subject: Re: CONFIG_EARLY_PRINTK
Date: Fri, 22 Mar 2013 15:07:34 +0100 [thread overview]
Message-ID: <1363961254.11400.8.camel@localhost.localdomain> (raw)
In-Reply-To: <5144AE20.7030202@infradead.org>
Am Samstag, den 16.03.2013, 10:38 -0700 schrieb Randy Dunlap:
> On 03/16/13 08:08, Thomas Meyer wrote:
> > Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
> > Yes,
> >
> > so why not do this? As the text to EARLY_PRINTK explains?
>
> Yes, the default should match the help text.
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Please resend your patch with Signed-off-by: line.
>
> Thanks.
Align EARLY_PRINTK default value with help text value.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index b322f12..852d51c 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -32,7 +32,6 @@ config X86_VERBOSE_BOOTUP
config EARLY_PRINTK
bool "Early printk" if EXPERT
- default y
---help---
Write kernel log output directly into the VGA buffer or to a serial
port.
next prev parent reply other threads:[~2013-03-22 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 17:15 CONFIG_EARLY_PRINTK Thomas Meyer
2013-03-13 19:56 ` CONFIG_EARLY_PRINTK Randy Dunlap
2013-03-16 15:08 ` CONFIG_EARLY_PRINTK Thomas Meyer
2013-03-16 17:38 ` CONFIG_EARLY_PRINTK Randy Dunlap
2013-03-16 20:10 ` CONFIG_EARLY_PRINTK Geert Uytterhoeven
2013-03-22 14:07 ` Thomas Meyer [this message]
2013-03-25 23:23 ` CONFIG_EARLY_PRINTK Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363961254.11400.8.camel@localhost.localdomain \
--to=thomas@m3y3r.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.