From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ5yC-0000Nf-Cg for qemu-devel@nongnu.org; Fri, 22 Mar 2013 13:41:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJ5y7-0001IL-Iq for qemu-devel@nongnu.org; Fri, 22 Mar 2013 13:41:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ5y7-0001I9-An for qemu-devel@nongnu.org; Fri, 22 Mar 2013 13:41:31 -0400 From: Kevin Wolf Date: Fri, 22 Mar 2013 18:41:10 +0100 Message-Id: <1363974083-28440-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1363974083-28440-1-git-send-email-kwolf@redhat.com> References: <1363974083-28440-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 01/14] Revert "block: complete all IOs before .bdrv_truncate" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Peter Lieven brdv_truncate() is also called from readv/writev commands on self- growing file based storage. this will result in requests waiting for theirselves to complete. This reverts commit 9a665b2b8640e464f0a778216fc2dca8d02acf33. Signed-off-by: Kevin Wolf --- block.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/block.c b/block.c index 0a062c9..22647b2 100644 --- a/block.c +++ b/block.c @@ -2487,10 +2487,6 @@ int bdrv_truncate(BlockDriverState *bs, int64_t offset) return -EACCES; if (bdrv_in_use(bs)) return -EBUSY; - - /* There better not be any in-flight IOs when we truncate the device. */ - bdrv_drain_all(); - ret = drv->bdrv_truncate(bs, offset); if (ret == 0) { ret = refresh_total_sectors(bs, offset >> BDRV_SECTOR_BITS); -- 1.8.1.4