From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices
Date: Sat, 12 Jul 2014 00:30:34 +0200 [thread overview]
Message-ID: <13642580.3DAGicjMse@xps13> (raw)
In-Reply-To: <1405024369-30058-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
About the form of the patch, I have 2 comments:
1) A doc explaining the design, the dependencies and how it can be used would
be a great help. Could you write it in rst format?
2) checkpatch.pl returns these errors:
ERROR:SPACING: space required before the open parenthesis '('
#468: FILE: lib/librte_pmd_packet/rte_eth_packet.c:250:
+ if(sockfd != -1)
ERROR:SPACING: space required before the open parenthesis '('
#471: FILE: lib/librte_pmd_packet/rte_eth_packet.c:253:
+ if(sockfd != -1)
ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#712: FILE: lib/librte_pmd_packet/rte_eth_packet.c:494:
+ ifr.ifr_name[ifnamelen]='\0';
Thanks
--
Thomas
next prev parent reply other threads:[~2014-07-11 22:30 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 20:32 [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices John W. Linville
[not found] ` <D0158A423229094DA7ABF71CF2FA0DA3117D3A23@shsmsx102.ccr.corp.intel.com>
[not found] ` <D0158A423229094DA7ABF71CF2FA0DA3117D3A23-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 17:20 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A8A13E6-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 17:40 ` John W. Linville
[not found] ` <20140711174042.GE25478-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-11 18:01 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A8A14B1-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 18:46 ` John W. Linville
[not found] ` <20140711184648.GH25478-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-12 0:42 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A8A186D-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-14 13:45 ` John W. Linville
2014-07-11 22:34 ` Thomas Monjalon
2014-07-14 13:46 ` John W. Linville
[not found] ` <20140714134616.GC27848-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-15 21:27 ` Thomas Monjalon
2014-07-16 12:35 ` Neil Horman
[not found] ` <20140716123530.GA22437-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-07-16 13:37 ` Thomas Monjalon
2014-07-16 14:07 ` John W. Linville
[not found] ` <20140716140744.GD13555-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-16 14:26 ` Thomas Monjalon
2014-07-16 15:59 ` Shaw, Jeffrey B
2014-07-11 19:04 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A8A150F-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 19:31 ` John W. Linville
[not found] ` <20140711193139.GJ25478-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-11 20:27 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A8A154C-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 20:31 ` Shaw, Jeffrey B
[not found] ` <4032A54B6BB5F04B8C08B6CFF08C59285544ECD5-AtyAts71sc9Qxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 20:35 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A8A16E3-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 20:40 ` John W. Linville
[not found] ` <1405024369-30058-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-11 13:11 ` Stephen Hemminger
2014-07-11 14:49 ` John W. Linville
[not found] ` <20140711144912.GA25478-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-11 15:06 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B0343ACD8B-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 15:16 ` Stephen Hemminger
2014-07-11 16:07 ` Richardson, Bruce
2014-07-11 15:29 ` Venkatesan, Venky
[not found] ` <1FD9B82B8BF2CF418D9A1000154491D974124465-P5GAC/sN6hlcIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 15:33 ` John W. Linville
[not found] ` <20140711153309.GD25478-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-11 16:29 ` Venkatesan, Venky
2014-07-11 13:26 ` Thomas Monjalon
2014-07-11 14:51 ` John W. Linville
[not found] ` <20140711145152.GB25478-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-11 15:04 ` Thomas Monjalon
2014-07-11 15:30 ` John W. Linville
[not found] ` <20140711153006.GC25478-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-11 16:47 ` Thomas Monjalon
2014-07-11 17:38 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B0343ACEB1-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-11 17:41 ` John W. Linville
2014-07-12 11:48 ` Neil Horman
2014-07-11 22:30 ` Thomas Monjalon [this message]
2014-07-14 17:53 ` John W. Linville
2014-07-11 22:51 ` Bruce Richardson
[not found] ` <20140711225108.GA9381-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>
2014-07-14 13:48 ` John W. Linville
[not found] ` <20140714134832.GD27848-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-14 17:35 ` John W. Linville
2014-07-14 18:24 ` [PATCH v2] " John W. Linville
[not found] ` <1405362290-6753-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-15 0:15 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A8A4F83-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-15 12:17 ` Neil Horman
[not found] ` <20140715121743.GA14273-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-07-15 14:01 ` John W. Linville
[not found] ` <20140715140111.GA26012-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-07-15 15:40 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A8AF52C-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-07-15 19:08 ` John W. Linville
2014-07-15 20:31 ` Neil Horman
[not found] ` <20140715203108.GA20273-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-07-15 20:41 ` Zhou, Danny
2014-07-15 15:34 ` Zhou, Danny
2014-09-12 18:05 ` John W. Linville
[not found] ` <20140912180523.GB7145-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-09-12 18:31 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A935AEE-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-12 18:54 ` John W. Linville
[not found] ` <20140912185423.GD7145-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-09-12 20:35 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A935E75-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-15 15:09 ` Neil Horman
[not found] ` <20140915150946.GA11690-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-09-15 15:15 ` John W. Linville
2014-09-15 15:43 ` Zhou, Danny
[not found] ` <DFDF335405C17848924A094BC35766CF0A93A24C-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-15 16:22 ` Neil Horman
[not found] ` <20140915162244.GB11690-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-09-15 17:48 ` John W. Linville
[not found] ` <20140915174822.GG28459-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-09-15 19:11 ` Zhou, Danny
2014-09-16 20:16 ` Neil Horman
[not found] ` <20140916201601.GF3792-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-09-26 9:28 ` Thomas Monjalon
2014-09-26 14:08 ` Neil Horman
[not found] ` <20140926140855.GD3930-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-09-29 10:05 ` Bruce Richardson
2014-10-08 15:57 ` Thomas Monjalon
2014-10-08 19:14 ` Neil Horman
[not found] ` <20141008191403.GB13306-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-11-13 10:03 ` Thomas Monjalon
2014-11-13 11:14 ` Neil Horman
[not found] ` <20141113111428.GA13253-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-11-13 11:57 ` Thomas Monjalon
2014-11-14 0:42 ` Neil Horman
[not found] ` <20141114004208.GA14230-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-11-14 14:45 ` John W. Linville
[not found] ` <20141114144536.GC1893-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-11-17 15:57 ` [PATCH v3] librte_pmd_af_packet: " John W. Linville
[not found] ` <1416239878-3556-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-11-24 16:16 ` Thomas Monjalon
2014-11-17 11:19 ` [PATCH v2] librte_pmd_packet: " Neil Horman
[not found] ` <20141117111919.GA17886-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-11-17 11:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13642580.3DAGicjMse@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.