From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [Intel-gfx] [PATCH] drm/i915: Always call fence-lost prior to removing the fence Date: Tue, 26 Mar 2013 16:25:58 +0200 Message-ID: <1364307958.2358.3.camel@intelbox> References: <1364294370-9204-1-git-send-email-chris@chris-wilson.co.uk> <1364297367-17947-1-git-send-email-chris@chris-wilson.co.uk> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1364297367-17947-1-git-send-email-chris@chris-wilson.co.uk> Sender: stable-owner@vger.kernel.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Daniel Vetter , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 2013-03-26 at 11:29 +0000, Chris Wilson wrote: > There is a minute window for a race between put-fence removing the fence > and for a new transaction by an external party on the GTT mmap. That is > we must zap the mmap prior to removing the fence and not afterwards. > > Fixes regression from > commit 61050808bb019ebea966b7b5bfd357aaf219fb51 > Author: Chris Wilson > Date: Tue Apr 17 15:31:31 2012 +0100 > > drm/i915: Refactor put_fence() to use the common fence writing routine > > v2: Remember the fence to remove with a local variable (gcc) > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: stable@vger.kernel.org # regression introduced in v3.5 Reviewed-by: Imre Deak