All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] poky.conf: enable Wayland DISTRO_FEATURE
@ 2013-03-27 13:59 Ross Burton
  2013-03-27 14:58 ` Chris Larson
  0 siblings, 1 reply; 4+ messages in thread
From: Ross Burton @ 2013-03-27 13:59 UTC (permalink / raw)
  To: poky

Without the Wayland feature you don't get the Wayland EGL platform built into
Mesa, so Poky can't be used to test Wayland or Weston properly out of the box.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta-yocto/conf/distro/poky.conf |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-yocto/conf/distro/poky.conf b/meta-yocto/conf/distro/poky.conf
index f146f5f..afe328b 100644
--- a/meta-yocto/conf/distro/poky.conf
+++ b/meta-yocto/conf/distro/poky.conf
@@ -11,7 +11,7 @@ TARGET_VENDOR = "-poky"
 LOCALCONF_VERSION = "1"
 LAYER_CONF_VERSION ?= "6"
 
-DISTRO_FEATURES_append = " largefile opengl multiarch"
+DISTRO_FEATURES_append = " largefile opengl multiarch wayland"
 
 PREFERRED_VERSION_linux-yocto ?= "3.4%"
 PREFERRED_VERSION_linux-yocto_qemux86 ?= "3.8%"
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] poky.conf: enable Wayland DISTRO_FEATURE
  2013-03-27 13:59 [PATCH] poky.conf: enable Wayland DISTRO_FEATURE Ross Burton
@ 2013-03-27 14:58 ` Chris Larson
  2013-03-27 15:05   ` Richard Purdie
  0 siblings, 1 reply; 4+ messages in thread
From: Chris Larson @ 2013-03-27 14:58 UTC (permalink / raw)
  To: Ross Burton; +Cc: poky@yoctoproject.org

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

On Wed, Mar 27, 2013 at 6:59 AM, Ross Burton <ross.burton@intel.com> wrote:

> Without the Wayland feature you don't get the Wayland EGL platform built
> into
> Mesa, so Poky can't be used to test Wayland or Weston properly out of the
> box.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta-yocto/conf/distro/poky.conf |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-yocto/conf/distro/poky.conf
> b/meta-yocto/conf/distro/poky.conf
> index f146f5f..afe328b 100644
> --- a/meta-yocto/conf/distro/poky.conf
> +++ b/meta-yocto/conf/distro/poky.conf
> @@ -11,7 +11,7 @@ TARGET_VENDOR = "-poky"
>  LOCALCONF_VERSION = "1"
>  LAYER_CONF_VERSION ?= "6"
>
> -DISTRO_FEATURES_append = " largefile opengl multiarch"
> +DISTRO_FEATURES_append = " largefile opengl multiarch wayland"
>

This reminds me, could we make this overridable? There are distros which
are based on poky, but might want to tweak the supported features. Perhaps
these features could be shoved into a separate variable and _append that,
or just use +=.
-- 
Christopher Larson

[-- Attachment #2: Type: text/html, Size: 1576 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] poky.conf: enable Wayland DISTRO_FEATURE
  2013-03-27 14:58 ` Chris Larson
@ 2013-03-27 15:05   ` Richard Purdie
  2013-03-27 15:19     ` Martin Jansa
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2013-03-27 15:05 UTC (permalink / raw)
  To: Chris Larson; +Cc: poky@yoctoproject.org

On Wed, 2013-03-27 at 07:58 -0700, Chris Larson wrote:
> 
> On Wed, Mar 27, 2013 at 6:59 AM, Ross Burton <ross.burton@intel.com>
> wrote:
>         Without the Wayland feature you don't get the Wayland EGL
>         platform built into
>         Mesa, so Poky can't be used to test Wayland or Weston properly
>         out of the box.
>         
>         Signed-off-by: Ross Burton <ross.burton@intel.com>
>         ---
>          meta-yocto/conf/distro/poky.conf |    2 +-
>          1 file changed, 1 insertion(+), 1 deletion(-)
>         
>         diff --git a/meta-yocto/conf/distro/poky.conf
>         b/meta-yocto/conf/distro/poky.conf
>         index f146f5f..afe328b 100644
>         --- a/meta-yocto/conf/distro/poky.conf
>         +++ b/meta-yocto/conf/distro/poky.conf
>         @@ -11,7 +11,7 @@ TARGET_VENDOR = "-poky"
>          LOCALCONF_VERSION = "1"
>          LAYER_CONF_VERSION ?= "6"
>         
>         -DISTRO_FEATURES_append = " largefile opengl multiarch"
>         +DISTRO_FEATURES_append = " largefile opengl multiarch
>         wayland"
> 
> This reminds me, could we make this overridable? There are distros
> which are based on poky, but might want to tweak the supported
> features. Perhaps these features could be shoved into a separate
> variable and _append that, or just use +=.

Sounds fine, please send a patch. There was some good reason for using
_append iirc.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] poky.conf: enable Wayland DISTRO_FEATURE
  2013-03-27 15:05   ` Richard Purdie
@ 2013-03-27 15:19     ` Martin Jansa
  0 siblings, 0 replies; 4+ messages in thread
From: Martin Jansa @ 2013-03-27 15:19 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Chris Larson, poky@yoctoproject.org

[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]

On Wed, Mar 27, 2013 at 03:05:12PM +0000, Richard Purdie wrote:
> On Wed, 2013-03-27 at 07:58 -0700, Chris Larson wrote:
> > 
> > On Wed, Mar 27, 2013 at 6:59 AM, Ross Burton <ross.burton@intel.com>
> > wrote:
> >         Without the Wayland feature you don't get the Wayland EGL
> >         platform built into
> >         Mesa, so Poky can't be used to test Wayland or Weston properly
> >         out of the box.
> >         
> >         Signed-off-by: Ross Burton <ross.burton@intel.com>
> >         ---
> >          meta-yocto/conf/distro/poky.conf |    2 +-
> >          1 file changed, 1 insertion(+), 1 deletion(-)
> >         
> >         diff --git a/meta-yocto/conf/distro/poky.conf
> >         b/meta-yocto/conf/distro/poky.conf
> >         index f146f5f..afe328b 100644
> >         --- a/meta-yocto/conf/distro/poky.conf
> >         +++ b/meta-yocto/conf/distro/poky.conf
> >         @@ -11,7 +11,7 @@ TARGET_VENDOR = "-poky"
> >          LOCALCONF_VERSION = "1"
> >          LAYER_CONF_VERSION ?= "6"
> >         
> >         -DISTRO_FEATURES_append = " largefile opengl multiarch"
> >         +DISTRO_FEATURES_append = " largefile opengl multiarch
> >         wayland"
> > 
> > This reminds me, could we make this overridable? There are distros
> > which are based on poky, but might want to tweak the supported
> > features. Perhaps these features could be shoved into a separate
> > variable and _append that, or just use +=.
> 
> Sounds fine, please send a patch. There was some good reason for using
> _append iirc.

I guess it was to use weak assignment from default-distrovars.inc
instead of replacing it with only these 3.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-03-27 15:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-27 13:59 [PATCH] poky.conf: enable Wayland DISTRO_FEATURE Ross Burton
2013-03-27 14:58 ` Chris Larson
2013-03-27 15:05   ` Richard Purdie
2013-03-27 15:19     ` Martin Jansa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.