From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Cristian Iorga <cristian.iorga@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] lsb: distro codename info added
Date: Fri, 29 Mar 2013 16:25:36 +0000 [thread overview]
Message-ID: <1364574336.28471.194.camel@ted> (raw)
In-Reply-To: <1364566362-16292-1-git-send-email-cristian.iorga@intel.com>
On Fri, 2013-03-29 at 16:12 +0200, Cristian Iorga wrote:
> Poky distro codename info added to /etc/lsb-release file.
> lsb_release script will not complain anymore about
> the incompleteness of /etc/lsb-release file by
> returning an error code.
> Increases LSB compliance.
>
> Partial fix for [YOCTO #4071].
>
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
> meta/recipes-extended/lsb/lsb_4.1.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
What about people who haven't set DISTRO_CODENAME?
Cheers,
Richard
> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
> index 01368b3..b28e9b6 100644
> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "LSB support for OpenEmbedded"
> SECTION = "console/utils"
> HOMEPAGE = "http://prdownloads.sourceforge.net/lsb"
> LICENSE = "GPLv2+"
> -PR = "r1"
> +PR = "r2"
>
> # lsb_release needs getopt
> RDEPENDS_${PN} += "util-linux"
> @@ -41,6 +41,7 @@ do_install(){
> echo "\"" >> ${D}${sysconfdir}/lsb-release
> echo "DISTRIB_ID=${DISTRO}" >> ${D}${sysconfdir}/lsb-release
> echo "DISTRIB_RELEASE=${DISTRO_VERSION}" >> ${D}${sysconfdir}/lsb-release
> + echo "DISTRIB_CODENAME=${DISTRO_CODENAME}" >> ${D}${sysconfdir}/lsb-release
> echo "DISTRIB_DESCRIPTION=\"${DISTRO_NAME} ${DISTRO_VERSION}\"" >> ${D}${sysconfdir}/lsb-release
>
> if [ "${TARGET_ARCH}" = "i586" ];then
next prev parent reply other threads:[~2013-03-29 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 14:12 [PATCH 3/3] lsb: distro codename info added Cristian Iorga
2013-03-29 16:25 ` Richard Purdie [this message]
2013-03-29 16:42 ` Iorga, Cristian
2013-03-29 17:02 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364574336.28471.194.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=cristian.iorga@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.