All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
Cc: Andy Whitcroft <apw@canonical.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: do not exit in main process subroutine
Date: Sun, 31 Mar 2013 21:55:37 -0600	[thread overview]
Message-ID: <1364788537.8705.10.camel@ubuntu> (raw)
In-Reply-To: <5156BECE.9070701@huawei.com>

On Sat, 2013-03-30 at 18:30 +0800, zhangwei(Jovi) wrote:
> On 2013/3/28 11:43, zhangwei(Jovi) wrote:
> > Currently checkpatch program exit when process empty file,
> > This will cause issue when @ARGV include many files ready to check.
[]
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > @@ -3634,19 +3634,19 @@ sub process {
> >  	# If we have no input at all, then there is nothing to report on
> >  	# so just keep quiet.
> >  	if ($#rawlines == -1) {
> > -		exit(0);
> > +		return $clean;
> >  	}

I think instead this should be something like adding

	if (!is_patch && $#rawlines == -1) {
		return $clean;
	}

though maybe expecting checkpatch to avoid empty files
when fed a directory list is unrealistic.



      parent reply	other threads:[~2013-04-01  3:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28  3:43 [PATCH] checkpatch: do not exit in main process subroutine zhangwei(Jovi)
2013-03-30 10:30 ` zhangwei(Jovi)
2013-03-31  4:30   ` Joe Perches
2013-04-01  3:55   ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364788537.8705.10.camel@ubuntu \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.