All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ewan Milne <emilne@redhat.com>
To: "Stewart, Sean" <Sean.Stewart@netapp.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"James.Bottomley@suse.de" <James.Bottomley@suse.de>,
	"snitzer@redhat.com" <snitzer@redhat.com>,
	"hare@suse.de" <hare@suse.de>
Subject: Re: [PATCH] scsi_dh_alua: Add module parameter to allow failover to non preferred path without STPG
Date: Mon, 01 Apr 2013 10:24:40 -0400	[thread overview]
Message-ID: <1364826280.3828.120.camel@localhost.localdomain> (raw)
In-Reply-To: <8255ED565A0EAA4A960625E27D49DBF21FF906FB@SACEXCMBX04-PRD.hq.netapp.com>

On Thu, 2013-03-28 at 22:07 +0000, Stewart, Sean wrote:
> +static uint optimize_stpg;
> +module_param(optimize_stpg, uint, S_IRUGO|S_IWUSR);
> +MODULE_PARM_DESC(optimize_stpg, "Send STPG command for Failover on non-preferred path(0=Yes,1=No). Default is 0.");

Could you possibly reword the description?  When I first read this, it
seemed backwards to have 0=Yes and 1=No.

-Ewan D. Milne <emilne@redhat.com>




  parent reply	other threads:[~2013-04-01 14:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28 22:07 [PATCH] scsi_dh_alua: Add module parameter to allow failover to non preferred path without STPG Stewart, Sean
2013-03-31 16:24 ` Hannes Reinecke
2013-04-01 14:24 ` Ewan Milne [this message]
2013-04-01 21:18   ` Stewart, Sean
2013-04-02 12:38     ` Ewan Milne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364826280.3828.120.camel@localhost.localdomain \
    --to=emilne@redhat.com \
    --cc=James.Bottomley@suse.de \
    --cc=Sean.Stewart@netapp.com \
    --cc=dm-devel@redhat.com \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.