diff for duplicates of <1365025110.25627.15@snotra> diff --git a/a/1.txt b/N1/1.txt index d41e6f4..6b565b8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -63,7 +63,8 @@ in between that referenced it. > > case 0x90: > > case 0xA0: > > case 0xB0: -> > - retval > > - openpic_cpu_read_internal(opp, addr, +> > - retval = +> > - openpic_cpu_read_internal(opp, addr, > get_current_cpu()); > > + retval = openpic_cpu_read_internal(opp, addr, > > + &retval, get_current_cpu()); @@ -91,7 +92,7 @@ should be used. As the comment says, I'm just being nice to hexdumps and such, which are unlikely to use 16-bit accesses. > > + */ -> > + if (len = 4) { +> > + if (len == 4) { > > + if (addr & 3) { > > + pr_debug("%s: bad alignment %llx/%d\n", > > + __func__, addr, len); @@ -115,7 +116,7 @@ another shot, though. > > + > > + pr_debug("%s: addr %llx ret %d len 4 val %x\n", > > + __func__, addr, ret, *(const u32 *)ptr); -> > + } else if (len = 1) { +> > + } else if (len == 1) { > > + union { > > + u32 val; > > + u8 bytes[4]; diff --git a/a/content_digest b/N1/content_digest index 5f742dd..d181578 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,11 +1,11 @@ "ref\0A6072B5C-C638-4DDB-8269-5BDF211C5701@suse.de\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [RFC PATCH v3 5/6] kvm/ppc/mpic: in-kernel MPIC emulation\0" - "Date\0Wed, 03 Apr 2013 21:38:30 +0000\0" + "Date\0Wed, 3 Apr 2013 16:38:30 -0500\0" "To\0Alexander Graf <agraf@suse.de>\0" - "Cc\0kvm-ppc@vger.kernel.org" - kvm@vger.kernel.org - " paulus@samba.org\0" + "Cc\0<kvm-ppc@vger.kernel.org>" + <kvm@vger.kernel.org> + " <paulus@samba.org>\0" "\00:1\0" "b\0" "On 04/03/2013 11:19:42 AM, Alexander Graf wrote:\n" @@ -73,7 +73,8 @@ "> > \tcase 0x90:\n" "> > \tcase 0xA0:\n" "> > \tcase 0xB0:\n" - "> > -\t\tretval > > -\t\t openpic_cpu_read_internal(opp, addr, \n" + "> > -\t\tretval =\n" + "> > -\t\t openpic_cpu_read_internal(opp, addr, \n" "> get_current_cpu());\n" "> > +\t\tretval = openpic_cpu_read_internal(opp, addr,\n" "> > +\t\t\t&retval, get_current_cpu());\n" @@ -101,7 +102,7 @@ "and such, which are unlikely to use 16-bit accesses.\n" "\n" "> > +\t */\n" - "> > +\tif (len = 4) {\n" + "> > +\tif (len == 4) {\n" "> > +\t\tif (addr & 3) {\n" "> > +\t\t\tpr_debug(\"%s: bad alignment %llx/%d\\n\",\n" "> > +\t\t\t\t __func__, addr, len);\n" @@ -125,7 +126,7 @@ "> > +\n" "> > +\t\tpr_debug(\"%s: addr %llx ret %d len 4 val %x\\n\",\n" "> > +\t\t\t __func__, addr, ret, *(const u32 *)ptr);\n" - "> > +\t} else if (len = 1) {\n" + "> > +\t} else if (len == 1) {\n" "> > +\t\tunion {\n" "> > +\t\t\tu32 val;\n" "> > +\t\t\tu8 bytes[4];\n" @@ -210,4 +211,4 @@ "\n" -Scott -d210699721164a1d9182e0ac3192aa447a6d5364a339b439ef18fb5d1c559519 +f056b051edd038d4584fbbd6d5391126fe6a47bafeda202d650d4e4dea350843
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.