diff for duplicates of <1365031408.25627.19@snotra> diff --git a/a/1.txt b/N1/1.txt index a32ae61..ac3340d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ On 04/03/2013 05:07:30 PM, Scott Wood wrote: > On 04/03/2013 04:58:56 PM, Alexander Graf wrote: ->> ->> +>>=20 +>>=20 >> Am 03.04.2013 um 23:38 schrieb Scott Wood <scottwood@freescale.com>: ->> +>>=20 >> > On 04/03/2013 11:19:42 AM, Alexander Graf wrote: >> >> On 03.04.2013, at 03:57, Scott Wood wrote: >> >> > + switch (attr->group) { @@ -11,31 +11,31 @@ On 04/03/2013 05:07:30 PM, Scott Wood wrote: >> >> > + switch (attr->attr) { >> >> > + case KVM_DEV_MPIC_BASE_ADDR: >> >> > + mutex_lock(&opp->kvm->slots_lock); ->> >> > + attr64 = opp->reg_base; +>> >> > + attr64 =3D opp->reg_base; >> >> > + mutex_unlock(&opp->kvm->slots_lock); >> >> > + >> >> > + if (copy_to_user((u64 __user *)(long)attr->addr, >> >> > + &attr64, sizeof(u64))) ->> >> u64 is tricky with put_user on 32bit hosts, so here copy_to_user +>> >> u64 is tricky with put_user on 32bit hosts, so here copy_to_user =20 >> makes sense >> > ->> > What are the issues with put_user? It looks like it's supported +>> > What are the issues with put_user? It looks like it's supported =20 >> with a pair of "stw" instructions. ->> ->> Oh? Last time I tried to use get/put_user for one_reg it failed on +>>=20 +>> Oh? Last time I tried to use get/put_user for one_reg it failed on =20 >> ppc32. So maybe the u64 support is new? -> -> Not new according to git -- though I haven't tried to use it yet; +>=20 +> Not new according to git -- though I haven't tried to use it yet; =20 > maybe it's broken. Yeah, it's broken. :-P -__get_user_size() looks OK, but __get_user_check/nocheck() goes through +__get_user_size() looks OK, but __get_user_check/nocheck() goes through =20 an intermediary "unsigned long __gu_val". -There's a separate __get_user64_nocheck() that uses "long long", but no -"check" variant, no "put", and it's only available in 32-bit builds. -And it's not used anywhere (barring ungreppable token-pasting magic). +There's a separate __get_user64_nocheck() that uses "long long", but no =20 +"check" variant, no "put", and it's only available in 32-bit builds. =20 +And it's not used anywhere (barring ungreppable token-pasting magic). =20 Sigh. --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index c90c6dc..3c24cee 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,21 +1,21 @@ "ref\01365026850.25627.16@snotra\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [RFC PATCH v3 5/6] kvm/ppc/mpic: in-kernel MPIC emulation\0" - "Date\0Wed, 03 Apr 2013 23:23:28 +0000\0" + "Date\0Wed, 3 Apr 2013 18:23:28 -0500\0" "To\0Scott Wood <scottwood@freescale.com>\0" - "Cc\0Alexander Graf <agraf@suse.de>" - <kvm-ppc@vger.kernel.org> <kvm-ppc@vger.kernel.org> - <kvm@vger.kernel.org> <kvm@vger.kernel.org> + "Cc\0linuxppc-dev@lists.ozlabs.org" <paulus@samba.org> <paulus@samba.org> - " linuxppc-dev@lists.ozlabs.org\0" + Alexander Graf <agraf@suse.de> + <kvm-ppc@vger.kernel.org> <kvm-ppc@vger.kernel.org> + " <kvm@vger.kernel.org> <kvm@vger.kernel.org>\0" "\00:1\0" "b\0" "On 04/03/2013 05:07:30 PM, Scott Wood wrote:\n" "> On 04/03/2013 04:58:56 PM, Alexander Graf wrote:\n" - ">> \n" - ">> \n" + ">>=20\n" + ">>=20\n" ">> Am 03.04.2013 um 23:38 schrieb Scott Wood <scottwood@freescale.com>:\n" - ">> \n" + ">>=20\n" ">> > On 04/03/2013 11:19:42 AM, Alexander Graf wrote:\n" ">> >> On 03.04.2013, at 03:57, Scott Wood wrote:\n" ">> >> > + switch (attr->group) {\n" @@ -23,33 +23,33 @@ ">> >> > + switch (attr->attr) {\n" ">> >> > + case KVM_DEV_MPIC_BASE_ADDR:\n" ">> >> > + mutex_lock(&opp->kvm->slots_lock);\n" - ">> >> > + attr64 = opp->reg_base;\n" + ">> >> > + attr64 =3D opp->reg_base;\n" ">> >> > + mutex_unlock(&opp->kvm->slots_lock);\n" ">> >> > +\n" ">> >> > + if (copy_to_user((u64 __user *)(long)attr->addr,\n" ">> >> > + &attr64, sizeof(u64)))\n" - ">> >> u64 is tricky with put_user on 32bit hosts, so here copy_to_user \n" + ">> >> u64 is tricky with put_user on 32bit hosts, so here copy_to_user =20\n" ">> makes sense\n" ">> >\n" - ">> > What are the issues with put_user? It looks like it's supported \n" + ">> > What are the issues with put_user? It looks like it's supported =20\n" ">> with a pair of \"stw\" instructions.\n" - ">> \n" - ">> Oh? Last time I tried to use get/put_user for one_reg it failed on \n" + ">>=20\n" + ">> Oh? Last time I tried to use get/put_user for one_reg it failed on =20\n" ">> ppc32. So maybe the u64 support is new?\n" - "> \n" - "> Not new according to git -- though I haven't tried to use it yet; \n" + ">=20\n" + "> Not new according to git -- though I haven't tried to use it yet; =20\n" "> maybe it's broken.\n" "\n" "Yeah, it's broken. :-P\n" "\n" - "__get_user_size() looks OK, but __get_user_check/nocheck() goes through \n" + "__get_user_size() looks OK, but __get_user_check/nocheck() goes through =20\n" "an intermediary \"unsigned long __gu_val\".\n" "\n" - "There's a separate __get_user64_nocheck() that uses \"long long\", but no \n" - "\"check\" variant, no \"put\", and it's only available in 32-bit builds. \n" - "And it's not used anywhere (barring ungreppable token-pasting magic). \n" + "There's a separate __get_user64_nocheck() that uses \"long long\", but no =20\n" + "\"check\" variant, no \"put\", and it's only available in 32-bit builds. =20\n" + "And it's not used anywhere (barring ungreppable token-pasting magic). =20\n" "Sigh.\n" "\n" - -Scott + -Scott= -be4009ce6f864b19cb06d6b2dfcb54fab5fb3102696de0a6d1bf86d3e9048940 +1fab01cf940e7bdc356e61fd445fdde27cf257d90044e7653df629a4d56df03b
diff --git a/a/content_digest b/N2/content_digest index c90c6dc..d2e7377 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,13 +1,13 @@ "ref\01365026850.25627.16@snotra\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [RFC PATCH v3 5/6] kvm/ppc/mpic: in-kernel MPIC emulation\0" - "Date\0Wed, 03 Apr 2013 23:23:28 +0000\0" + "Date\0Wed, 3 Apr 2013 18:23:28 -0500\0" "To\0Scott Wood <scottwood@freescale.com>\0" "Cc\0Alexander Graf <agraf@suse.de>" <kvm-ppc@vger.kernel.org> <kvm-ppc@vger.kernel.org> <kvm@vger.kernel.org> <kvm@vger.kernel.org> <paulus@samba.org> <paulus@samba.org> - " linuxppc-dev@lists.ozlabs.org\0" + " <linuxppc-dev@lists.ozlabs.org>\0" "\00:1\0" "b\0" "On 04/03/2013 05:07:30 PM, Scott Wood wrote:\n" @@ -52,4 +52,4 @@ "\n" -Scott -be4009ce6f864b19cb06d6b2dfcb54fab5fb3102696de0a6d1bf86d3e9048940 +ee925e4e8b95dabc6d2d71c8ebf3d888df4e3a9b1a0124a82c8ba89b0b51c912
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.