diff for duplicates of <1365100904.14772.12@snotra> diff --git a/a/1.txt b/N1/1.txt index cd2f266..e1b7b59 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ On 04/04/2013 07:54:20 AM, Alexander Graf wrote: > > On 03.04.2013, at 03:57, Scott Wood wrote: > -> > + if (opp->mpic_mode_mask = GCR_MODE_PROXY) +> > + if (opp->mpic_mode_mask == GCR_MODE_PROXY) > > Shouldn't this be an &? @@ -10,7 +10,7 @@ The way the mode field was originally documented was a two-bit field, where 0b11 was external proxy, and 0b10 was reserved. If we use & it would have to be: - if ((opp->mpic_mode_mask & GCR_MODE_PROXY) = GCR_MODE_PROXY) + if ((opp->mpic_mode_mask & GCR_MODE_PROXY) == GCR_MODE_PROXY) ... Simply testing "opp->mpic_mode_mask & GCR_MODE_PROXY" would return true diff --git a/a/content_digest b/N1/content_digest index 14f3378..eeeaff6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,18 +1,18 @@ "ref\037191669-BF8E-4DAC-B3A0-98F0820C3208@suse.de\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC\0" - "Date\0Thu, 04 Apr 2013 18:41:44 +0000\0" + "Date\0Thu, 4 Apr 2013 13:41:44 -0500\0" "To\0Alexander Graf <agraf@suse.de>\0" - "Cc\0kvm-ppc@vger.kernel.org" - kvm@vger.kernel.org - " paulus@samba.org\0" + "Cc\0<kvm-ppc@vger.kernel.org>" + <kvm@vger.kernel.org> + " <paulus@samba.org>\0" "\00:1\0" "b\0" "On 04/04/2013 07:54:20 AM, Alexander Graf wrote:\n" "> \n" "> On 03.04.2013, at 03:57, Scott Wood wrote:\n" "> \n" - "> > +\tif (opp->mpic_mode_mask = GCR_MODE_PROXY)\n" + "> > +\tif (opp->mpic_mode_mask == GCR_MODE_PROXY)\n" "> \n" "> Shouldn't this be an &?\n" "\n" @@ -20,7 +20,7 @@ "where 0b11 was external proxy, and 0b10 was reserved. If we use & it \n" "would have to be:\n" "\n" - "\tif ((opp->mpic_mode_mask & GCR_MODE_PROXY) = GCR_MODE_PROXY)\n" + "\tif ((opp->mpic_mode_mask & GCR_MODE_PROXY) == GCR_MODE_PROXY)\n" "\t\t...\n" "\n" "Simply testing \"opp->mpic_mode_mask & GCR_MODE_PROXY\" would return true \n" @@ -50,4 +50,4 @@ "\n" -Scott -ed349a60b16a3c5f83dfe8806e1e74c4bf09c94d74abaa288a3f5bb5d68ac15d +974348ef773a1c2d9c16f725c9a773238b38075678657b08a201f78858843eee
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.