diff for duplicates of <1365114959.14772.18@snotra> diff --git a/a/1.txt b/N1/1.txt index d30a68d..a511cb5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,14 +5,14 @@ On 04/04/2013 05:30:05 PM, Alexander Graf wrote: > > > On 04/04/2013 07:54:20 AM, Alexander Graf wrote: > >> On 03.04.2013, at 03:57, Scott Wood wrote: -> >> > + if (opp->mpic_mode_mask = GCR_MODE_PROXY) +> >> > + if (opp->mpic_mode_mask == GCR_MODE_PROXY) > >> Shouldn't this be an &? > > > > The way the mode field was originally documented was a two-bit > field, where 0b11 was external proxy, and 0b10 was reserved. If we > use & it would have to be: > > -> > if ((opp->mpic_mode_mask & GCR_MODE_PROXY) = GCR_MODE_PROXY) +> > if ((opp->mpic_mode_mask & GCR_MODE_PROXY) == GCR_MODE_PROXY) > > ... > > > > Simply testing "opp->mpic_mode_mask & GCR_MODE_PROXY" would return @@ -26,7 +26,7 @@ On 04/04/2013 05:30:05 PM, Alexander Graf wrote: > Ok, please add a comment about this here then :). What sort of comment would you like? Or do you want me to use the "(x -& y) = y" version? +& y) == y" version? > >> > @@ -460,6 +464,13 @@ void kvm_arch_vcpu_free(struct kvm_vcpu > *vcpu) diff --git a/a/content_digest b/N1/content_digest index d3aeb6b..29f645f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\02C5A4219-A912-4909-AE8E-63B8309AD27F@suse.de\0" "From\0Scott Wood <scottwood@freescale.com>\0" "Subject\0Re: [RFC PATCH v3 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC\0" - "Date\0Thu, 04 Apr 2013 22:35:59 +0000\0" + "Date\0Thu, 4 Apr 2013 17:35:59 -0500\0" "To\0Alexander Graf <agraf@suse.de>\0" "Cc\0<kvm-ppc@vger.kernel.org> <kvm-ppc@vger.kernel.org>" <kvm@vger.kernel.org> <kvm@vger.kernel.org> @@ -16,14 +16,14 @@ "> \n" "> > On 04/04/2013 07:54:20 AM, Alexander Graf wrote:\n" "> >> On 03.04.2013, at 03:57, Scott Wood wrote:\n" - "> >> > + if (opp->mpic_mode_mask = GCR_MODE_PROXY)\n" + "> >> > + if (opp->mpic_mode_mask == GCR_MODE_PROXY)\n" "> >> Shouldn't this be an &?\n" "> >\n" "> > The way the mode field was originally documented was a two-bit \n" "> field, where 0b11 was external proxy, and 0b10 was reserved. If we \n" "> use & it would have to be:\n" "> >\n" - "> > if ((opp->mpic_mode_mask & GCR_MODE_PROXY) = GCR_MODE_PROXY)\n" + "> > if ((opp->mpic_mode_mask & GCR_MODE_PROXY) == GCR_MODE_PROXY)\n" "> > ...\n" "> >\n" "> > Simply testing \"opp->mpic_mode_mask & GCR_MODE_PROXY\" would return \n" @@ -37,7 +37,7 @@ "> Ok, please add a comment about this here then :).\n" "\n" "What sort of comment would you like? Or do you want me to use the \"(x \n" - "& y) = y\" version?\n" + "& y) == y\" version?\n" "\n" "> >> > @@ -460,6 +464,13 @@ void kvm_arch_vcpu_free(struct kvm_vcpu \n" "> *vcpu)\n" @@ -65,4 +65,4 @@ "\n" -Scott -2176f1db15e7072137aa7933dc758bb133886f74ad2771835492544a896b381b +7623dad2cf1cfff26407394b7e12fc40f242d07bba6a62818ea186ee04f2f535
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.