All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5][v2] powerpc/mpc85xx:No NOR boot, do not compile IFC errata A003399
Date: Fri, 5 Apr 2013 15:33:53 -0500	[thread overview]
Message-ID: <1365194033.17535.9@snotra> (raw)
In-Reply-To: <1363936068-17107-1-git-send-email-prabhakar@freescale.com> (from prabhakar@freescale.com on Fri Mar 22 02:07:48 2013)

On 03/22/2013 02:07:48 AM, Prabhakar Kushwaha wrote:
> IFC errata A003399 is valid for IFC NOR boot i.e.if no on-board NOR  
> flash or
> no NOR boot, do not compile its workaround.
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
>  Based upon git://git.denx.de/u-boot.git branch master
>  Changes for v2:
>  	- Add CONFIG_A003399_NOR_WORKAROUND for errata workaround
> 	- Add CONFIG_A003399_NOR_WORKAROUND in README
> 
>  README                                    |    4 ++++
>  arch/powerpc/cpu/mpc85xx/cpu_init_early.c |    9 ++++++---
>  arch/powerpc/cpu/mpc8xxx/fsl_ifc.c        |    2 +-
>  3 files changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/README b/README
> index 7f2506a..c4ad69d 100644
> --- a/README
> +++ b/README
> @@ -414,6 +414,10 @@ The following options need to be configured:
>  		See Freescale App Note 4493 for more information about
>  		this erratum.
> 
> +		CONFIG_A003399_NOR_WORKAROUND
> +		Enables a workaround for IFC erratum A003399. It is only
> +		requred during NOR boot.
> +
>  		CONFIG_SYS_FSL_CORENET_SNOOPVEC_COREONLY
> 
>  		This is the value to write into CCSR offset 0x18600
> diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c  
> b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> index dacfdd1..3a4bfc5 100644
> --- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> +++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
> @@ -25,7 +25,8 @@
> 
>  DECLARE_GLOBAL_DATA_PTR;
> 
> -#if defined(CONFIG_SYS_FSL_ERRATUM_IFC_A003399) &&  
> !defined(CONFIG_SYS_RAMBOOT)
> +#if defined(CONFIG_SYS_FSL_ERRATUM_IFC_A003399)\
> +	&& defined(CONFIG_A003399_NOR_WORKAROUND)

Why would CONFIG_A003399_NOR_WORKAROUND be enabled if  
CONFIG_SYS_FSL_ERRATUM_IFC_A003399 isn't?

-Scott

  reply	other threads:[~2013-04-05 20:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22  7:07 [U-Boot] [PATCH 1/5][v2] powerpc/mpc85xx:No NOR boot, do not compile IFC errata A003399 Prabhakar Kushwaha
2013-04-05 20:33 ` Scott Wood [this message]
2013-04-06  2:28   ` Prabhakar Kushwaha
2013-04-09  0:39     ` Scott Wood
2013-04-09  4:56       ` Prabhakar Kushwaha
2013-04-09 23:41         ` Scott Wood
2013-04-10  3:57           ` Prabhakar Kushwaha
2013-04-10 20:09             ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365194033.17535.9@snotra \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.