From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Bengt Jonsson <bengt.g.jonsson@stericsson.com>,
Lee Jones <lee.jones@linaro.org>,
Yvan FILLION <yvan.fillion@stericsson.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] regulator: ab8500: Fix get_mode for shared mode regulators
Date: Mon, 08 Apr 2013 20:31:14 +0800 [thread overview]
Message-ID: <1365424274.21989.2.camel@phoenix> (raw)
The special handling code for getting shared mode status is wrong
because it needs to check info->shared_mode->lp_mode_req for
both regulators that shared the same mode register.
In set_mode(), current code ensures we won't set mode to REGULATOR_MODE_IDLE
if only one of the regulator requests to set idle.
In get_mode(), we can just remove the special handling code for shared mode.
Read the register value always returns correct status no matter the regulator
has shared mode register or not.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/ab8500.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index 9ebd131..acdffc5 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -456,14 +456,6 @@ static unsigned int ab8500_regulator_get_mode(struct regulator_dev *rdev)
return -EINVAL;
}
- /* Need special handling for shared mode */
- if (info->shared_mode) {
- if (info->shared_mode->lp_mode_req)
- return REGULATOR_MODE_IDLE;
- else
- return REGULATOR_MODE_NORMAL;
- }
-
if (info->mode_mask) {
/* Dedicated register for handling mode */
ret = abx500_get_register_interruptible(info->dev,
--
1.7.10.4
next reply other threads:[~2013-04-08 12:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 12:31 Axel Lin [this message]
2013-04-13 14:10 ` [PATCH] regulator: ab8500: Fix get_mode for shared mode regulators Axel Lin
2013-04-15 8:09 ` Lee Jones
2013-04-15 8:03 ` Bengt Jönsson
2013-04-15 8:34 ` Axel Lin
2013-04-15 8:50 ` Axel Lin
2013-04-15 11:34 ` Bengt Jönsson
2013-04-15 12:13 ` Axel Lin
2013-04-15 12:41 ` Bengt Jönsson
2013-04-15 14:11 ` Axel Lin
2013-04-15 14:48 ` Bengt Jönsson
2013-04-15 16:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365424274.21989.2.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=bengt.g.jonsson@stericsson.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yvan.fillion@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.