From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Chanho Min <chanho.min@lge.com>,
Nadia Yvette Chambers <nyc@holomorphy.com>,
Jiri Kosina <jkosina@suse.cz>, Guennadi Liakhovetski <lg@denx.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] bitmap: speedup in bitmap_find_free_region when order is 0
Date: Mon, 08 Apr 2013 20:18:20 -0700 [thread overview]
Message-ID: <1365477500.2012.5.camel@joe-AO722> (raw)
In-Reply-To: <20130408201001.f4c74887.akpm@linux-foundation.org>
On Mon, 2013-04-08 at 20:10 -0700, Andrew Morton wrote:
> > --- a/lib/bitmap.c
[]
> > + for (i = 0 ; i < nlongs_reg ; i++) {
>
> No space before the semicolon, please. checkpatch should warn about
> this but it seems to be broken.
There's no specific CodingStyle violation here
Adding --strict does bleat though.
# check for whitespace before a non-naked semicolon
if ($line =~ /^\+.*\S\s+;/) {
CHK("SPACING",
"space prohibited before semicolon\n" . $herecurr);
}
next prev parent reply other threads:[~2013-04-09 3:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 2:44 [PATCH v2] bitmap: speedup in bitmap_find_free_region when order is 0 Chanho Min
2013-04-09 3:10 ` Andrew Morton
2013-04-09 3:18 ` Joe Perches [this message]
2013-04-09 4:18 ` Andrew Morton
2013-04-09 4:27 ` checkpatch: Warn on space before semicolon Joe Perches
[not found] ` <5163b689.64d3440a.731b.ffff9984SMTPIN_ADDED_BROKEN@mx.google.com>
2013-04-09 20:22 ` [PATCH v2] bitmap: speedup in bitmap_find_free_region when order is 0 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365477500.2012.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=chanho.min@lge.com \
--cc=jkosina@suse.cz \
--cc=lg@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nyc@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.