From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Subject: =?UTF-8?B?UmVbMl06IGxpbnV4LW5leHQ6IGJ1aWxkIGZhaWx1cmUgYWZ0ZXIgbWVyZ2Ug?= =?UTF-8?B?b2YgdGhlIG1mZCB0cmVl?= Date: Tue, 09 Apr 2013 19:47:40 +0400 Message-ID: <1365522460.690965802@f12.mail.ru> References: <20130408142124.ac540429a889cdc9800e529a@canb.auug.org.au> <1365438469.322553103@f51.mail.ru> <20130409072059.GC23447@zurbaran> Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 Return-path: Received: from f12.mail.ru ([217.69.128.79]:44975 "EHLO f12.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936173Ab3DIPro (ORCPT ); Tue, 9 Apr 2013 11:47:44 -0400 In-Reply-To: <20130409072059.GC23447@zurbaran> Sender: linux-next-owner@vger.kernel.org List-ID: To: =?UTF-8?B?U2FtdWVsIE9ydGl6?= Cc: =?UTF-8?B?U3RlcGhlbiBSb3Rod2VsbA==?= , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org PiBPbiBNb24sIEFwciAwOCwgMjAxMyBhdCAwODoyNzo0OVBNICswNDAwLCBBbGV4YW5kZXIgU2hp eWFuIHdyb3RlOgo+ID4gPiA+ID4gQWZ0ZXIgbWVyZ2luZyB0aGUgbWZkIHRyZWUsIHRvZGF5J3Mg bGludXgtbmV4dCBidWlsZCAoeDg2XzY0IGFsbG1vZGNvbmZpZykKPiA+ID4gPiA+IGZhaWxlZCBs aWtlIHRoaXM6Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IGRyaXZlcnMvcmVndWxhdG9yL2FuYXRvcC1y ZWd1bGF0b3IuYzogSW4gZnVuY3Rpb24gJ2FuYXRvcF9yZWd1bGF0b3JfcHJvYmUnOgo+ID4gPiA+ ID4gZHJpdmVycy9yZWd1bGF0b3IvYW5hdG9wLXJlZ3VsYXRvci5jOjEzNDoyOiBlcnJvcjogaW1w bGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24gJ29mX2dldF9wYXJlbnQnIFstV2Vycm9yPWlt cGxpY2l0LWZ1bmN0aW9uLWRlY2xhcmF0aW9uXQo+ID4gPiA+ID4gCj4gPiA+ID4gPiBDYXVzZWQg YnkgY29tbWl0IDVhYjNhODlhNzQxZiAoIm1mZDogc3lzY29uOiBBZGQgbm9uLURUIHN1cHBvcnQi KS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gSSBoYXZlIHVzZWQgdGhlIG1mZCB0cmVlIGZyb20gbmV4 dC0yMDEzMDQwNSBmb3IgdG9kYXkuCj4gPiA+ID4gCj4gPiA+ID4gVGhpcyBtZWFucyB0aGF0IHdl IGRvIG5vdCBoYXZlIGVtcHR5IGRlY2xhcmF0aW9ucyBmb3IgdGhlCj4gPiA+ID4gb2ZfeHggZnVu Y3Rpb25zIGluIGxpbnV4L29mLmggZm9yICFDT05GSUdfT0YuCj4gPiA+ID4gT0sgdG8gZGVjbGFy ZSB0aGVzZSBmdW5jdGlvbnMgb3IgYW55IG90aGVyIG9waW5pb25zPwo+ID4gPiBPayB3aXRoIG1l LCBidXQgeW91J2QgbmVlZCB0byBnZXQgR3JhbnQgYW5kIFJvYidzIEFDSy4KLi4uCj4gPiBTdWJq ZWN0OiBbUEFUQ0hdIHJlZ3VsYXRvcjogYW5hdG9wOiBNYWtlIHNlbGVjdCBkZXBlbmRlbmN5IGZy b20KPiA+ICBIQVZFX0lNWF9BTkFUT1Agc3ltYm9sCj4gPiAKPiA+IFRoaXMgcGF0Y2ggbWFrZSBz ZWxlY3Rpb24gb2YgYW5hdG9wLXJlZ3VsYXRvciBmcm9tIEhBVkVfSU1YX0FOQVRPUAo+ID4ga2Vy bmVsIHN5bWJvbC4gVGhpcyBmaXhlcyBidWlsZCBrZXJuZWwgd2l0aCBzeXNjb24gZHJpdmVyIGJ1 dCB3aXRob3V0Cj4gPiBvZnRyZWUgc3VwcG9ydC4KLi4uCj4gVGhpcyBkb2VzIGxvb2sgbGlrZSBh IGJhbmQtYWlkIHNvbHV0aW9uIHRvIG1lLiBZZXMsIGl0IHdpbGwgZml4IHRoZSBjcmFzaCwgYnV0 Cj4geW91J3JlIHJlc3RyaWN0aW5nIHRoaXMgY29kZSB0byBhIG11Y2ggc21hbGxlciBhcmNoaXRl Y3R1cmUgc2V0LiBBRkFJSwo+IGxpbnV4LW5leHQgaXMgbm90IHRlc3RlZCBvbiB0aGF0IGFyY2gs IGZvciBleGFtcGxlLgoKT0ssIHRoZSBzZWNvbmQgc29sdXRpb246CgpGcm9tIDMyOTY0MTVmMjk4 MThhNDMwYmFkMTJjOTJkYzY1Y2Q4MWU0ZDEzM2YgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCkZy b206IEFsZXhhbmRlciBTaGl5YW4gPHNoY193b3JrQG1haWwucnU+CkRhdGU6IFR1ZSwgOSBBcHIg MjAxMyAxOTo0MToyNyArMDQwMApTdWJqZWN0OiBbUEFUQ0hdIG9mOiBhZGQgc3R1YiBvZl9nZXRf cGFyZW50IGZvciBub24tT0YgYnVpbGRzCgpGaXhlcyBidWlsZCBlcnJvciBvbiB4ODZfNjQgYWxs bW9kY29uZmlnLCBpbnRyb2R1Y2VkIGJ5IGNvbW1pdAo1YWIzYTg5YTc0MWYgKCJtZmQ6IHN5c2Nv bjogQWRkIG5vbi1EVCBzdXBwb3J0IikuCgpkcml2ZXJzL3JlZ3VsYXRvci9hbmF0b3AtcmVndWxh dG9yLmM6IEluIGZ1bmN0aW9uICdhbmF0b3BfcmVndWxhdG9yX3Byb2JlJzoKZHJpdmVycy9yZWd1 bGF0b3IvYW5hdG9wLXJlZ3VsYXRvci5jOjEzNDoyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRp b24gb2YgZnVuY3Rpb24gJ29mX2dldF9wYXJlbnQnIFstV2Vycm9yPWltcGxpY2l0LWZ1bmN0aW9u LWRlY2xhcmF0aW9uXQoKU2lnbmVkLW9mZi1ieTogQWxleGFuZGVyIFNoaXlhbiA8c2hjX3dvcmtA bWFpbC5ydT4KLS0tCiBpbmNsdWRlL2xpbnV4L29mLmggfCA1ICsrKysrCiAxIGZpbGUgY2hhbmdl ZCwgNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9vZi5oIGIvaW5j bHVkZS9saW51eC9vZi5oCmluZGV4IGEwZjEyOTIuLjlmNTkyM2YgMTAwNjQ0Ci0tLSBhL2luY2x1 ZGUvbGludXgvb2YuaAorKysgYi9pbmNsdWRlL2xpbnV4L29mLmgKQEAgLTM1Myw2ICszNTMsMTEg QEAgc3RhdGljIGlubGluZSBzdHJ1Y3QgZGV2aWNlX25vZGUgKm9mX2ZpbmRfbm9kZV9ieV9uYW1l KHN0cnVjdCBkZXZpY2Vfbm9kZSAqZnJvbSwKIAlyZXR1cm4gTlVMTDsKIH0KIAorc3RhdGljIGlu bGluZSBzdHJ1Y3QgZGV2aWNlX25vZGUgKm9mX2dldF9wYXJlbnQoY29uc3Qgc3RydWN0IGRldmlj ZV9ub2RlICpub2RlKQoreworCXJldHVybiBOVUxMOworfQorCiBzdGF0aWMgaW5saW5lIGJvb2wg b2ZfaGF2ZV9wb3B1bGF0ZWRfZHQodm9pZCkKIHsKIAlyZXR1cm4gZmFsc2U7Ci0tIAoxLjguMS41 CgotLS0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936585Ab3DIPrp (ORCPT ); Tue, 9 Apr 2013 11:47:45 -0400 Received: from f12.mail.ru ([217.69.128.79]:44975 "EHLO f12.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936173Ab3DIPro (ORCPT ); Tue, 9 Apr 2013 11:47:44 -0400 From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= To: =?UTF-8?B?U2FtdWVsIE9ydGl6?= Cc: =?UTF-8?B?U3RlcGhlbiBSb3Rod2VsbA==?= , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?UTF-8?B?UmVbMl06IGxpbnV4LW5leHQ6IGJ1aWxkIGZhaWx1cmUgYWZ0ZXIgbWVyZ2Ug?= =?UTF-8?B?b2YgdGhlIG1mZCB0cmVl?= Mime-Version: 1.0 X-Mailer: Mail.Ru Mailer 1.0 X-Originating-IP: [188.134.40.128] Date: Tue, 09 Apr 2013 19:47:40 +0400 Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= X-Priority: 3 (Normal) Message-ID: <1365522460.690965802@f12.mail.ru> Content-Type: text/plain; charset=utf-8 X-Spam: Not detected X-Mras: Ok In-Reply-To: <20130409072059.GC23447@zurbaran> References: <20130408142124.ac540429a889cdc9800e529a@canb.auug.org.au> <1365438469.322553103@f51.mail.ru> <20130409072059.GC23447@zurbaran> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r39Flje0005207 > On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote: > > > > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig) > > > > > failed like this: > > > > > > > > > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': > > > > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] > > > > > > > > > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). > > > > > > > > > > I have used the mfd tree from next-20130405 for today. > > > > > > > > This means that we do not have empty declarations for the > > > > of_xx functions in linux/of.h for !CONFIG_OF. > > > > OK to declare these functions or any other opinions? > > > Ok with me, but you'd need to get Grant and Rob's ACK. ... > > Subject: [PATCH] regulator: anatop: Make select dependency from > > HAVE_IMX_ANATOP symbol > > > > This patch make selection of anatop-regulator from HAVE_IMX_ANATOP > > kernel symbol. This fixes build kernel with syscon driver but without > > oftree support. ... > This does look like a band-aid solution to me. Yes, it will fix the crash, but > you're restricting this code to a much smaller architecture set. AFAIK > linux-next is not tested on that arch, for example. OK, the second solution: >>From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001 From: Alexander Shiyan Date: Tue, 9 Apr 2013 19:41:27 +0400 Subject: [PATCH] of: add stub of_get_parent for non-OF builds Fixes build error on x86_64 allmodconfig, introduced by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support"). drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe': drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration] Signed-off-by: Alexander Shiyan --- include/linux/of.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/of.h b/include/linux/of.h index a0f1292..9f5923f 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from, return NULL; } +static inline struct device_node *of_get_parent(const struct device_node *node) +{ + return NULL; +} + static inline bool of_have_populated_dt(void) { return false; -- 1.8.1.5 --- {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I