From: Imre Deak <imre.deak@intel.com>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Add ECOBITS_SNB_BIT
Date: Tue, 09 Apr 2013 19:23:18 +0300 [thread overview]
Message-ID: <1365524598.2352.0.camel@intelbox> (raw)
In-Reply-To: <1365077622-4605-1-git-send-email-ville.syrjala@linux.intel.com>
On Thu, 2013-04-04 at 15:13 +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> GAC_ECO_BITS has a bit similar to GAM_ECOCHK's ECOCHK_SNB_BIT. Add
> the define, and enable it on SNB.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
On the series:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++-
> drivers/gpu/drm/i915/i915_reg.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 24a23b3..593137b 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -312,7 +312,8 @@ void i915_gem_init_ppgtt(struct drm_device *dev)
> uint32_t ecochk, gab_ctl, ecobits;
>
> ecobits = I915_READ(GAC_ECO_BITS);
> - I915_WRITE(GAC_ECO_BITS, ecobits | ECOBITS_PPGTT_CACHE64B);
> + I915_WRITE(GAC_ECO_BITS, ecobits | ECOBITS_SNB_BIT |
> + ECOBITS_PPGTT_CACHE64B);
>
> gab_ctl = I915_READ(GAB_CTL);
> I915_WRITE(GAB_CTL, gab_ctl | GAB_CTL_CONT_AFTER_PAGEFAULT);
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 058686c..4b8fd4d 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -127,6 +127,7 @@
> #define ECOCHK_PPGTT_CACHE4B (0x0<<3)
>
> #define GAC_ECO_BITS 0x14090
> +#define ECOBITS_SNB_BIT (1<<13)
> #define ECOBITS_PPGTT_CACHE64B (3<<8)
> #define ECOBITS_PPGTT_CACHE4B (0<<8)
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-04-09 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 12:13 [PATCH 1/3] drm/i915: Add ECOBITS_SNB_BIT ville.syrjala
2013-04-04 12:13 ` [PATCH 2/3] drm/i915: Set GAC_ECO_BITS register on Gen7+ ville.syrjala
2013-04-04 12:13 ` [PATCH 3/3] drm/i915: Configure GAM_ECOCHK appropriatly for Gen7 ville.syrjala
2013-04-09 16:23 ` Imre Deak [this message]
2013-04-09 17:01 ` [PATCH 1/3] drm/i915: Add ECOBITS_SNB_BIT Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365524598.2352.0.camel@intelbox \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.