From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Alessio Igor Bogani <abogani@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Metcalf <cmetcalf@tilera.com>,
Christoph Lameter <cl@linux.com>,
Geoff Levand <geoff@infradead.org>,
Gilad Ben Yossef <gilad@benyossef.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Li Zhong <zhong@linux.vnet.ibm.com>,
Namhyung Kim <namhyung.kim@lge.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Turner <pjt@google.com>, Mike Galbraith <efault@gmx.de>
Subject: Re: [RFC GIT PULL] nohz: Full dynticks rq clock handling
Date: Wed, 10 Apr 2013 12:26:43 +0200 [thread overview]
Message-ID: <1365589603.30071.37.camel@laptop> (raw)
In-Reply-To: <1365266760-24725-1-git-send-email-fweisbec@gmail.com>
Another thing I just noticed; our update_curr() assumes its called at
least once every 4 odd seconds (2^32 ns like).
update_curr() is 'required' for things like task runtime stats and
everything that hangs off of that like cputimers etc.
Now I'm not entirely sure how the nr_running==1 nohz case deals with
this, but I can imagine it might take a while. In this case we might
need to 'fix' update_curr() to not asume the time delta fits in 32
bits.
next prev parent reply other threads:[~2013-04-10 10:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 16:45 [RFC GIT PULL] nohz: Full dynticks rq clock handling Frederic Weisbecker
2013-04-06 16:45 ` [PATCH 1/7] sched: Update rq clock on nohz CPU before migrating tasks Frederic Weisbecker
2013-04-08 11:48 ` Ingo Molnar
2013-04-09 9:13 ` Peter Zijlstra
2013-04-09 13:11 ` Frederic Weisbecker
2013-04-06 16:45 ` [PATCH 2/7] sched: Update rq clock on nohz CPU before setting fair group shares Frederic Weisbecker
2013-04-09 9:26 ` Peter Zijlstra
2013-04-09 13:21 ` Frederic Weisbecker
2013-04-10 7:05 ` Peter Zijlstra
2013-04-10 10:06 ` Ingo Molnar
2013-04-10 11:02 ` Peter Zijlstra
2013-04-10 11:06 ` Ingo Molnar
2013-04-10 11:47 ` Peter Zijlstra
2013-04-10 11:50 ` Ingo Molnar
2013-04-06 16:45 ` [PATCH 3/7] sched: Update rq clock on tickless CPUs before calling check_preempt_curr() Frederic Weisbecker
2013-04-09 13:18 ` Peter Zijlstra
2013-04-09 16:53 ` Frederic Weisbecker
2013-04-06 16:45 ` [PATCH 4/7] sched: Update rq clock earlier in unthrottle_cfs_rq Frederic Weisbecker
2013-04-06 16:45 ` [PATCH 5/7] sched: Update rq clock before idle balancing Frederic Weisbecker
2013-04-06 16:45 ` [PATCH 6/7] sched: Use an accessor to read rq clock Frederic Weisbecker
2013-04-06 16:46 ` [PATCH 7/7] sched: Debug nohz " Frederic Weisbecker
2013-04-10 10:26 ` Peter Zijlstra [this message]
2013-04-10 10:29 ` [RFC GIT PULL] nohz: Full dynticks rq clock handling Ingo Molnar
2013-04-11 15:11 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365589603.30071.37.camel@laptop \
--to=peterz@infradead.org \
--cc=abogani@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=geoff@infradead.org \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.