From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 02 of 11 v5] xen, libxc: introduce xc_nodemap_t Date: Wed, 10 Apr 2013 18:41:14 +0200 Message-ID: <1365612074.13103.139.camel@Solace> References: <0af169dd6279b184d29f.1365609900@hit-nxdomain.opendns.com> <5165AD0102000078000CC38B@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0497895428385010946==" Return-path: In-Reply-To: <5165AD0102000078000CC38B@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Marcus Granado , Dan Magenheimer , Ian Campbell , Anil Madhavapeddy , George Dunlap , Andrew Cooper , Juergen Gross , Ian Jackson , "xen-devel@lists.xen.org" , Matt Wilson , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org --===============0497895428385010946== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-fmlaxDFHWswfyA4qmQO+" --=-fmlaxDFHWswfyA4qmQO+ Content-Type: multipart/mixed; boundary="=-d29ZxvV//+zcln8jrZCa" --=-d29ZxvV//+zcln8jrZCa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2013-04-10 at 17:18 +0100, Jan Beulich wrote: > > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > > --- a/xen/common/domctl.c > > +++ b/xen/common/domctl.c > > @@ -117,6 +117,20 @@ int xenctl_bitmap_to_cpumask(cpumask_var > > return err; > > } > > =20 > > +int nodemask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_nodemap, > > + const nodemask_t *nodemask) > > +{ > > + return bitmap_to_xenctl_bitmap(xenctl_nodemap, cpumask_bits(nodema= sk), >=20 > This can hardly be cpumask_bits(). If you don't have a similar node > mask accessor already, you should create one rather than abusing > the CPU mask one. >=20 Wow... Impressive it survived this late! :-/ There is one, it's nodes_addr(), I just have to use it here. The patch attached to this mail does that, let me know if it looks better/fine, as well as if it is fine to pick it up from here, or I have to respin the whole series. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-d29ZxvV//+zcln8jrZCa Content-Disposition: attachment; filename="libxc-introduce-xc_nodemap_t" Content-Type: text/plain; name="libxc-introduce-xc_nodemap_t"; charset="UTF-8" Content-Transfer-Encoding: base64 IyBIRyBjaGFuZ2VzZXQgcGF0Y2gNCiMgUGFyZW50IDk5NWYwYjNkNmM5YmZmYjE0NzEzN2Y4NTBi ZjNmYWRmZmU3MzVjM2ENCnhlbiwgbGlieGM6IGludHJvZHVjZSB4Y19ub2RlbWFwX3QNCg0KQW5k IGl0cyBoYW5kbGluZyBmdW5jdGlvbnMsIGZvbGxvd2luZyBzdWl0IGZyb20geGNfY3B1bWFwX3Qu DQoNClNpZ25lZC1vZmYtYnk6IERhcmlvIEZhZ2dpb2xpIDxkYXJpby5mYWdnaW9saUBjaXRyaXgu Y29tPg0KQWNrZWQtYnk6IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAZXUuY2l0cml4LmNv bT4NCkFja2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqdWVyZ2VuLmdyb3NzQHRzLmZ1aml0c3UuY29t Pg0KLS0tDQpDaGFuZ2VzIGZyb20gdjI6DQogKiBEaXNjcmltaW5hdGluZyBiZXR3ZWVuIHN0YXRp Y2FsbHkgYWxsb2NhdGVkIG5vZGVtYXNrX3QgYW5kDQogICBkeW5hbWljYWxseSBhbGxvY2F0ZWQg bm9kZW1hc2tfdmFyX3QgaXMgbm90IHJlYWxseSBuZWNlc3NzYXJ5LA0KICAgZ2l2ZW4gdGhlIG1h eGltdW0gbnVtYmVyIG9mIG5vZGVzIHdvbid0IGV2ZXIgZ3JvdyB0aGF0IG11Y2gsDQogICBzbyBr aWxsZWQgdGhhdCBodW5rLCBhcyBzdWdnZXN0ZWQgZHVyaW5nIHJldmlldy4NCg0KZGlmZiAtLWdp dCBhL3Rvb2xzL2xpYnhjL3hjX21pc2MuYyBiL3Rvb2xzL2xpYnhjL3hjX21pc2MuYw0KLS0tIGEv dG9vbHMvbGlieGMveGNfbWlzYy5jDQorKysgYi90b29scy9saWJ4Yy94Y19taXNjLmMNCkBAIC01 NCw2ICs1NCwxMSBAQCBpbnQgeGNfZ2V0X2NwdW1hcF9zaXplKHhjX2ludGVyZmFjZSAqeGNoDQog ICAgIHJldHVybiAoeGNfZ2V0X21heF9jcHVzKHhjaCkgKyA3KSAvIDg7DQogfQ0KIA0KK2ludCB4 Y19nZXRfbm9kZW1hcF9zaXplKHhjX2ludGVyZmFjZSAqeGNoKQ0KK3sNCisgICAgcmV0dXJuICh4 Y19nZXRfbWF4X25vZGVzKHhjaCkgKyA3KSAvIDg7DQorfQ0KKw0KIHhjX2NwdW1hcF90IHhjX2Nw dW1hcF9hbGxvYyh4Y19pbnRlcmZhY2UgKnhjaCkNCiB7DQogICAgIGludCBzejsNCkBAIC02NCw2 ICs2OSwxNiBAQCB4Y19jcHVtYXBfdCB4Y19jcHVtYXBfYWxsb2MoeGNfaW50ZXJmYWNlDQogICAg IHJldHVybiBjYWxsb2MoMSwgc3opOw0KIH0NCiANCit4Y19ub2RlbWFwX3QgeGNfbm9kZW1hcF9h bGxvYyh4Y19pbnRlcmZhY2UgKnhjaCkNCit7DQorICAgIGludCBzejsNCisNCisgICAgc3ogPSB4 Y19nZXRfbm9kZW1hcF9zaXplKHhjaCk7DQorICAgIGlmIChzeiA9PSAwKQ0KKyAgICAgICAgcmV0 dXJuIE5VTEw7DQorICAgIHJldHVybiBjYWxsb2MoMSwgc3opOw0KK30NCisNCiBpbnQgeGNfcmVh ZGNvbnNvbGVyaW5nKHhjX2ludGVyZmFjZSAqeGNoLA0KICAgICAgICAgICAgICAgICAgICAgICAg Y2hhciAqYnVmZmVyLA0KICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50ICpwbnJf Y2hhcnMsDQpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGMveGVuY3RybC5oIGIvdG9vbHMvbGlieGMv eGVuY3RybC5oDQotLS0gYS90b29scy9saWJ4Yy94ZW5jdHJsLmgNCisrKyBiL3Rvb2xzL2xpYnhj L3hlbmN0cmwuaA0KQEAgLTMzMCwxMiArMzMwLDIwIEBAIGludCB4Y19nZXRfY3B1bWFwX3NpemUo eGNfaW50ZXJmYWNlICp4Y2gNCiAvKiBhbGxvY2F0ZSBhIGNwdW1hcCAqLw0KIHhjX2NwdW1hcF90 IHhjX2NwdW1hcF9hbGxvYyh4Y19pbnRlcmZhY2UgKnhjaCk7DQogDQotIC8qDQorLyoNCiAgKiBO T0RFTUFQIGhhbmRsaW5nDQogICovDQordHlwZWRlZiB1aW50OF90ICp4Y19ub2RlbWFwX3Q7DQor DQogLyogcmV0dXJuIG1heGltdW0gbnVtYmVyIG9mIE5VTUEgbm9kZXMgdGhlIGh5cGVydmlzb3Ig c3VwcG9ydHMgKi8NCiBpbnQgeGNfZ2V0X21heF9ub2Rlcyh4Y19pbnRlcmZhY2UgKnhjaCk7DQog DQorLyogcmV0dXJuIGFycmF5IHNpemUgZm9yIG5vZGVtYXAgKi8NCitpbnQgeGNfZ2V0X25vZGVt YXBfc2l6ZSh4Y19pbnRlcmZhY2UgKnhjaCk7DQorDQorLyogYWxsb2NhdGUgYSBub2RlbWFwICov DQoreGNfbm9kZW1hcF90IHhjX25vZGVtYXBfYWxsb2MoeGNfaW50ZXJmYWNlICp4Y2gpOw0KKw0K IC8qDQogICogRE9NQUlOIERFQlVHR0lORyBGVU5DVElPTlMNCiAgKi8NCmRpZmYgLS1naXQgYS94 ZW4vY29tbW9uL2RvbWN0bC5jIGIveGVuL2NvbW1vbi9kb21jdGwuYw0KLS0tIGEveGVuL2NvbW1v bi9kb21jdGwuYw0KKysrIGIveGVuL2NvbW1vbi9kb21jdGwuYw0KQEAgLTExNyw2ICsxMTcsMjAg QEAgaW50IHhlbmN0bF9iaXRtYXBfdG9fY3B1bWFzayhjcHVtYXNrX3Zhcg0KICAgICByZXR1cm4g ZXJyOw0KIH0NCiANCitpbnQgbm9kZW1hc2tfdG9feGVuY3RsX2JpdG1hcChzdHJ1Y3QgeGVuY3Rs X2JpdG1hcCAqeGVuY3RsX25vZGVtYXAsDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y29uc3Qgbm9kZW1hc2tfdCAqbm9kZW1hc2spDQorew0KKyAgICByZXR1cm4gYml0bWFwX3RvX3hl bmN0bF9iaXRtYXAoeGVuY3RsX25vZGVtYXAsIG5vZGVzX2FkZHIoKm5vZGVtYXNrKSwNCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE1BWF9OVU1OT0RFUyk7DQorfQ0KKw0KK2lu dCB4ZW5jdGxfYml0bWFwX3RvX25vZGVtYXNrKG5vZGVtYXNrX3QgKm5vZGVtYXNrLA0KKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCB4ZW5jdGxfYml0bWFwICp4ZW5j dGxfbm9kZW1hcCkNCit7DQorICAgIHJldHVybiB4ZW5jdGxfYml0bWFwX3RvX2JpdG1hcChub2Rl c19hZGRyKCpub2RlbWFzayksIHhlbmN0bF9ub2RlbWFwLA0KKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgTUFYX05VTU5PREVTKTsNCit9DQorDQogc3RhdGljIGlubGluZSBpbnQg aXNfZnJlZV9kb21pZChkb21pZF90IGRvbSkNCiB7DQogICAgIHN0cnVjdCBkb21haW4gKmQ7DQo= --=-d29ZxvV//+zcln8jrZCa-- --=-fmlaxDFHWswfyA4qmQO+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) iEYEABECAAYFAlFllioACgkQk4XaBE3IOsS2lQCcCsoL6im2IlObg0+y7MmGQXfI xv8AnRJBLdF5Syc2a/NeWCi08/OWdhVd =Xs73 -----END PGP SIGNATURE----- --=-fmlaxDFHWswfyA4qmQO+-- --===============0497895428385010946== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0497895428385010946==--