From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re[2]: [PATCH] GPIO: gpio-generic: Remove kfree() from bgpio_remove call
Date: Thu, 11 Apr 2013 21:38:53 +0400 [thread overview]
Message-ID: <1365701933.646047659@f77.mail.ru> (raw)
In-Reply-To: 1365701002-17292-1-git-send-email-shc_work@mail.ru
> On Thu, Apr 11, 2013 at 7:23 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
>
> > Memory for basic-mmio-gpio driver is allocated by resource managed
> > function, so using kfree() call in bgpio_remove is wrong.
> > This patch eliminates this kfree() call.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>
> So I think the patch is correct but the commit message is wrong.
>
> It is not certain at all that bgpio is resource managed, but the point
> of the patch should be that it's up to the driver using it to allocate
> and free its struct bgpio_chip, after calling this function.
>
> A quick glance on the consumers gives at hand that this is the case
> for all consumers, so I took the liberty to update the commit
> message and apply it...
OK, no problem.
---
prev parent reply other threads:[~2013-04-11 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 17:23 [PATCH] GPIO: gpio-generic: Remove kfree() from bgpio_remove call Alexander Shiyan
2013-04-11 17:35 ` Linus Walleij
2013-04-11 17:38 ` Alexander Shiyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365701933.646047659@f77.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.