From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 6/7] mtd: nand: add driver for diskonchip g4 nand flash
Date: Fri, 12 Apr 2013 12:34:01 -0500 [thread overview]
Message-ID: <1365788041.3640.27@snotra> (raw)
In-Reply-To: <201304121927.09245.marex@denx.de> (from marex@denx.de on Fri Apr 12 12:27:09 2013)
On 04/12/2013 12:27:09 PM, Marek Vasut wrote:
> Dear Scott Wood,
>
> [...]
> >
> > [snip]
> >
> > > +#ifdef DEBUG_DOCG4
> > > +#define dbg(format, arg...) printf("DEBUG: " format, ##arg)
> > > +#else
> > > +#define dbg(format, arg...) do {} while (0)
> > > +#endif
>
> There already is a debugging facility in include/common.h too. And it
> does the
> same thing too. MTDDEBUG might work as well.
I already pointed out MTDDEBUG, though debug() may be a better fit as
it doesn't require adding debug levels, and since this driver's usage
doesn't correspond to CONFIG_MTD_DEBUG in Linux (which appears to have
been removed from Linux -- removal from U-Boot should likely follow).
Mike said he may just remove the debug messages entirely (maybe also
from the Linux driver?), making it moot.
-Scott
next prev parent reply other threads:[~2013-04-12 17:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 0:45 [U-Boot] [PATCH v2 0/7] palm treo 680 smartphone board support Mike Dunn
2013-04-11 0:45 ` [U-Boot] [PATCH v2 1/7] pxa_lcd: add the ACX544AKN lcd device Mike Dunn
2013-04-11 19:14 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 2/7] pxa_lcd: make lcd_enable() a weak pointer Mike Dunn
2013-04-11 19:15 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 3/7] pxa27x_udc: remove call to unimplemented set_GPIO_mode() Mike Dunn
2013-04-11 19:16 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 4/7] arm: bootm: call udc_disable()before booting linux Mike Dunn
2013-04-11 19:18 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 5/7] lib: import bitrev library from the linux kernel Mike Dunn
2013-04-11 19:19 ` Marek Vasut
2013-04-12 12:01 ` Mike Dunn
2013-04-12 17:28 ` Marek Vasut
2013-04-13 19:27 ` Wolfgang Denk
2013-04-11 0:45 ` [U-Boot] [PATCH v2 6/7] mtd: nand: add driver for diskonchip g4 nand flash Mike Dunn
2013-04-11 19:19 ` Marek Vasut
2013-04-12 16:29 ` Scott Wood
2013-04-11 21:00 ` Scott Wood
2013-04-12 13:36 ` Mike Dunn
2013-04-12 17:27 ` Marek Vasut
2013-04-12 17:34 ` Scott Wood [this message]
2013-04-11 0:45 ` [U-Boot] [PATCH v2 7/7] add support for palm treo 680 board Mike Dunn
2013-04-11 19:20 ` Marek Vasut
2013-04-12 12:51 ` Mike Dunn
2013-04-12 17:26 ` Marek Vasut
2013-04-14 17:44 ` [U-Boot] [PATCH v2 0/7] palm treo 680 smartphone board support Marek Vasut
2013-04-14 20:10 ` Mike Dunn
2013-04-14 20:13 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365788041.3640.27@snotra \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.