From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: UBIFS: make space fixup work in the remount case
Date: Mon, 15 Apr 2013 13:11:33 +0300 [thread overview]
Message-ID: <1366020693.2768.41.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20130415095924.GA26544@elgon.mountain>
On Mon, 2013-04-15 at 12:59 +0300, Dan Carpenter wrote:
> 1571 if (c->space_fixup) {
> 1572 err = ubifs_fixup_free_space(c);
> 1573 if (err)
> 1574 return err;
> ^^^^^^^^^^
> Shouldn't this be a "goto out?". We're holding the c->umount_mutex.
Hi Dan, I fixed this up and answered the reporter:
https://patchwork.kernel.org/patch/2284681/
It is now 'goto out'. Thanks!
--
Best Regards,
Artem Bityutskiy
next parent reply other threads:[~2013-04-15 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130415095924.GA26544@elgon.mountain>
2013-04-15 10:11 ` Artem Bityutskiy [this message]
2013-04-15 10:19 ` UBIFS: make space fixup work in the remount case Dan Carpenter
2013-04-15 10:39 ` Artem Bityutskiy
2014-04-01 13:39 ` Dan Carpenter
2014-04-07 10:43 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366020693.2768.41.camel@sauron.fi.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.