All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: <netdev@vger.kernel.org>, <xen-devel@lists.xen.org>
Cc: <annie.li@oracle.com>, <konrad.wilk@oracle.com>,
	<jbeulich@suse.com>, <ian.campbell@citrix.com>,
	<wdauchy@gmail.com>, <david.vrabel@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH V5 3/7] xen-netback: remove skb in xen_netbk_alloc_page
Date: Mon, 15 Apr 2013 18:06:17 +0100	[thread overview]
Message-ID: <1366045581-31349-4-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1366045581-31349-1-git-send-email-wei.liu2@citrix.com>

This variable is never used.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
 drivers/net/xen-netback/netback.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index da726a3..6e8e51a 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -948,7 +948,6 @@ static int netbk_count_requests(struct xenvif *vif,
 }
 
 static struct page *xen_netbk_alloc_page(struct xen_netbk *netbk,
-					 struct sk_buff *skb,
 					 u16 pending_idx)
 {
 	struct page *page;
@@ -982,7 +981,7 @@ static struct gnttab_copy *xen_netbk_get_requests(struct xen_netbk *netbk,
 
 		index = pending_index(netbk->pending_cons++);
 		pending_idx = netbk->pending_ring[index];
-		page = xen_netbk_alloc_page(netbk, skb, pending_idx);
+		page = xen_netbk_alloc_page(netbk, pending_idx);
 		if (!page)
 			goto err;
 
@@ -1387,7 +1386,7 @@ static unsigned xen_netbk_tx_build_gops(struct xen_netbk *netbk)
 		}
 
 		/* XXX could copy straight to head */
-		page = xen_netbk_alloc_page(netbk, skb, pending_idx);
+		page = xen_netbk_alloc_page(netbk, pending_idx);
 		if (!page) {
 			kfree_skb(skb);
 			netbk_tx_err(vif, &txreq, idx);
-- 
1.7.10.4

  parent reply	other threads:[~2013-04-15 17:06 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 17:06 [PATCH V5 0/7] Bundle fixes for Xen netfront /netback Wei Liu
2013-04-15 17:06 ` [PATCH V5 1/7] xen-netfront: remove unused variable `extra' Wei Liu
2013-04-15 17:06 ` Wei Liu
2013-04-15 17:06 ` [PATCH V5 2/7] xen-netfront: frags -> slots in xennet_get_responses Wei Liu
2013-04-15 17:06 ` Wei Liu
2013-04-15 17:06 ` [PATCH V5 3/7] xen-netback: remove skb in xen_netbk_alloc_page Wei Liu
2013-04-15 17:06 ` Wei Liu [this message]
2013-04-15 17:06 ` [PATCH V5 4/7] xen-netfront: frags -> slots in log message Wei Liu
2013-04-15 17:06 ` Wei Liu
2013-04-17 13:48   ` Ian Campbell
2013-04-17 13:48   ` Ian Campbell
2013-04-15 17:06 ` [PATCH V5 5/7] xen-netfront: reduce gso_max_size to account for max TCP header Wei Liu
2013-04-17 13:51   ` Ian Campbell
2013-04-17 13:51   ` Ian Campbell
2013-04-15 17:06 ` Wei Liu
2013-04-15 17:06 ` [PATCH V5 6/7] xen-netback: coalesce slots in TX path and fix regressions Wei Liu
2013-04-17 13:53   ` Ian Campbell
2013-04-17 13:53   ` Ian Campbell
2013-04-21 22:06   ` annie li
2013-04-21 22:06   ` annie li
2013-04-22  9:28     ` Wei Liu
2013-04-22  9:28     ` Wei Liu
2013-04-30 18:06   ` annie li
2013-04-30 18:06   ` [Xen-devel] " annie li
2013-05-01  9:22     ` Wei Liu
2013-05-01  9:22     ` [Xen-devel] " Wei Liu
2013-04-15 17:06 ` Wei Liu
2013-04-15 17:06 ` [PATCH V5 7/7] xen-netback: don't disconnect frontend when seeing oversize packet Wei Liu
2013-04-15 17:06 ` Wei Liu
2013-04-15 17:38 ` [PATCH V5 0/7] Bundle fixes for Xen netfront /netback David Miller
2013-04-15 17:38 ` David Miller
2013-04-17 13:49   ` Ian Campbell
2013-04-17 13:49   ` Ian Campbell
2013-04-17 17:05     ` David Miller
2013-04-17 17:05     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366045581-31349-4-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=annie.li@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=wdauchy@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.