From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@gmail.com, dietmar@proxmox.com,
pbonzini@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH V3 0/5] block: make qmp_transaction extendable
Date: Fri, 19 Apr 2013 08:57:05 +0800 [thread overview]
Message-ID: <1366333030-8564-1-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
This serial will package backing chain snapshot code as one case, to make it
possible adding more operations later.
v2:
Address Kevin's comments:
Use the same prototype prepare, commit, rollback model in original code,
commit should never fail.
v3:
Address Stefan's comments:
3/5, 4/5: remove *action parameter since later only BlkTransactionStates* is
needed.
5/5: embbed BlkTransactionStates in ExternalSnapshotStates, *opaque is
removed, related call back function format change for external snapshot.
Address Kevin's comments:
removed all indention in commit message.
1/5: return void for prepare() function, *errp plays the role as error
checker.
5/5: mark *commit callback must exist, *rollback callback can be NULL. Align
"callback =" in "const BdrvActionOps external_snapshot_ops" to the same colum.
Address Eric's comments:
1/5: better commit message.
5/5: better commit message and comments in code that only one of rollback()
or commit() will be called.
Wenchao Xia (5):
1 block: package preparation code in qmp_transaction()
2 block: move input parsing code in qmp_transaction()
3 block: package committing code in qmp_transaction()
4 block: package rollback code in qmp_transaction()
5 block: make all steps in qmp_transaction() as callback
blockdev.c | 251 +++++++++++++++++++++++++++++++++++++++---------------------
1 files changed, 163 insertions(+), 88 deletions(-)
next reply other threads:[~2013-04-19 0:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 0:57 Wenchao Xia [this message]
2013-04-19 0:57 ` [Qemu-devel] [PATCH V3 1/5] block: package preparation code in qmp_transaction() Wenchao Xia
2013-04-19 0:57 ` [Qemu-devel] [PATCH V3 2/5] block: move input parsing " Wenchao Xia
2013-04-19 0:57 ` [Qemu-devel] [PATCH V3 3/5] block: package committing " Wenchao Xia
2013-04-19 0:57 ` [Qemu-devel] [PATCH V3 4/5] block: package rollback " Wenchao Xia
2013-04-19 0:57 ` [Qemu-devel] [PATCH V3 5/5] block: make all steps in qmp_transaction() as callback Wenchao Xia
2013-04-24 9:25 ` Stefan Hajnoczi
2013-04-25 8:13 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366333030-8564-1-git-send-email-xiawenc@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=dietmar@proxmox.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.