From: Cong Wang <amwang@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: A regression introduced by 802.1ad support patches
Date: Sun, 21 Apr 2013 17:49:17 +0800 [thread overview]
Message-ID: <1366537757.23100.11.camel@cr0> (raw)
In-Reply-To: <20130421093436.GA26775@macbook.localnet>
On Sun, 2013-04-21 at 11:34 +0200, Patrick McHardy wrote:
> commit 77734833d78bcf0a3f58cde8b5b2424e8fc8b7e6
> Author: Patrick McHardy <kaber@trash.net>
> Date: Sun Apr 21 11:34:12 2013 +0200
>
> net: vlan: fix memory leak in vlan_info_rcu_free()
>
> The following leak is reported by kmemleak:
>
> [ 86.812073] kmemleak: Found object by alias at
> 0xffff88006ecc76f0
> [ 86.816019] Pid: 739, comm: kworker/u:1 Not tainted 3.9.0-rc5+
> #842
> [ 86.816019] Call Trace:
> [ 86.816019] <IRQ> [<ffffffff81151c58>] find_and_get_object
> +0x8c/0xdf
> [ 86.816019] [<ffffffff8190e90d>] ? vlan_info_rcu_free
> +0x33/0x49
> [ 86.816019] [<ffffffff81151cbe>] delete_object_full+0x13/0x2f
> [ 86.816019] [<ffffffff8194bbb6>] kmemleak_free+0x26/0x45
> [ 86.816019] [<ffffffff8113e8c7>] slab_free_hook+0x1e/0x7b
> [ 86.816019] [<ffffffff81141c05>] kfree+0xce/0x14b
> [ 86.816019] [<ffffffff8190e90d>] vlan_info_rcu_free+0x33/0x49
> [ 86.816019] [<ffffffff810d0b0b>] rcu_do_batch+0x261/0x4e7
>
> The reason is that in vlan_info_rcu_free() we don't take the VLAN
> protocol
> into account when iterating over the vlan_devices_array.
>
> Reported-by: Cong Wang <amwang@redhat.com>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Yes, indeed.
Tested-by: Cong Wang <amwang@redhat.com>
next prev parent reply other threads:[~2013-04-21 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 7:43 A regression introduced by 802.1ad support patches Cong Wang
2013-04-21 9:34 ` Patrick McHardy
2013-04-21 9:49 ` Cong Wang [this message]
2013-04-21 19:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366537757.23100.11.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.