All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: David Stevens <dlstevens@us.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [Patch net-next v4 4/5] vxlan: add scope_id support for ll addr
Date: Sun, 21 Apr 2013 21:47:13 +0800	[thread overview]
Message-ID: <1366552033.23100.16.camel@cr0> (raw)
In-Reply-To: <OFA1761298.DF396ECD-ON85257B52.003AE2CA-85257B52.003DBDAB@us.ibm.com>

On Fri, 2013-04-19 at 07:14 -0400, David Stevens wrote:
> 
>         As I commented before, you're obscuring the types here,
> which makes it less readable. "va_sin6" ought to be a sockaddr_in6,
> not a sin6_addr, and the scope id ought to then be 
> "va_sin6.sin6_scope_id",
> without any other #define necessary for it.

So finally you want something like:

vxlan->default_dst.remote_ip.va_sin.sin_addr.s_addr

and

vxlan->default_dst.remote_ip.va_sin6.sin6_addr

Enjoy the readable code! :)

Again, I don't like this at all from the beginning! I just want to make
David happy. v5 is on the way...

For the record, please don't blame me if you think the code is ugly. :)

  parent reply	other threads:[~2013-04-21 13:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17  5:10 [Patch net-next v4 0/5] vxlan: add ipv6 support Cong Wang
2013-04-17  5:10 ` [Patch net-next v4 1/5] vxlan: defer vxlan init as late as possible Cong Wang
2013-04-17  5:10 ` [Patch net-next v4 2/5] ipv6: export ipv6_sock_mc_join and ipv6_sock_mc_drop Cong Wang
2013-04-17  5:10 ` [Patch net-next v4 3/5] vxlan: add ipv6 support Cong Wang
2013-04-17  8:15   ` Mike Rapoport
2013-04-17  9:57     ` Cong Wang
2013-04-17 10:36       ` Mike Rapoport
2013-04-17 13:18         ` Cong Wang
2013-04-17 16:34           ` Mike Rapoport
2013-04-18 14:34   ` Mike Rapoport
2013-04-19 11:35     ` Cong Wang
2013-04-17  5:10 ` [Patch net-next v4 4/5] vxlan: add scope_id support for ll addr Cong Wang
2013-04-18 13:36   ` Cong Wang
2013-04-19 11:14   ` David Stevens
2013-04-19 11:56     ` Cong Wang
2013-04-21 13:47     ` Cong Wang [this message]
2013-04-21 14:46       ` Bjørn Mork
2013-04-21 14:57         ` Cong Wang
2013-04-21 15:10           ` Bjørn Mork
2013-04-17  5:10 ` [Patch net-next v4 5/5] ipv6: Add generic UDP Tunnel segmentation Cong Wang
2013-04-18 17:23   ` Pravin Shelar
2013-04-19 11:30     ` Cong Wang
2013-04-17  5:10 ` [PATCH iproute2] vxlan: add ipv6 support Cong Wang
2013-04-18 22:55   ` Stephen Hemminger
2013-04-19 11:36     ` Cong Wang
2013-04-18 22:57   ` Stephen Hemminger
2013-04-19 14:20     ` Cong Wang
2013-04-19 15:26       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366552033.23100.16.camel@cr0 \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.