All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: dhowells@redhat.com, jlayton@redhat.com, smfrench@gmail.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH] iov_iter: Add extraction functions
Date: Fri, 14 Oct 2022 13:22:27 +0100	[thread overview]
Message-ID: <1366586.1665750147@warthog.procyon.org.uk> (raw)
In-Reply-To: <Yy5pzHiQ4GRCOoXV@ZenIV>

Al Viro <viro@zeniv.linux.org.uk> wrote:

> How is it better than "iov_iter_get_pages2() into a fixed-sized
> array and handle the result" done in a loop?

I did that first - and you objected on the basis that I shouldn't be taking
page refs if it's not necessary, and under some circumstances some of the
pages pointed to by the iterator might not be something that I should attempt
to take a ref on.

David


  reply	other threads:[~2022-10-14 12:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 23:18 [RFC][PATCH] iov_iter: Add extraction functions David Howells
2022-09-10 12:16 ` kernel test robot
2022-09-24  2:22 ` Al Viro
2022-10-14 12:22   ` David Howells [this message]
2022-10-18 14:29   ` David Howells
2022-10-18 14:48     ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2022-09-11  8:49 kernel test robot
2022-09-13  9:21 ` Dan Carpenter
2022-09-12  0:44 kernel test robot
2022-09-12 14:57 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366586.1665750147@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=smfrench@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.