All of lore.kernel.org
 help / color / mirror / Atom feed
From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
	jasowang@redhat.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH 2/5] [PATCH 2/3] tools: hv: fix checks for origin of netlink message in hv_vss_daemon
Date: Tue, 23 Apr 2013 13:58:37 -0700	[thread overview]
Message-ID: <1366750720-32667-2-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1366750720-32667-1-git-send-email-kys@microsoft.com>

From: Olaf Hering <olaf@aepfle.de> 

Similar to what commit 95a69adab9acfc3981c504737a2b6578e4d846ef ("tools:
hv: Netlink source address validation allows DoS") does in
hv_kvp_daemon, improve checks for origin of netlink connector message.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 tools/hv/hv_vss_daemon.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
index 2a03d0b..dc3eb1e 100644
--- a/tools/hv/hv_vss_daemon.c
+++ b/tools/hv/hv_vss_daemon.c
@@ -186,13 +186,19 @@ int main(void)
 		len = recvfrom(fd, vss_recv_buffer, sizeof(vss_recv_buffer), 0,
 				addr_p, &addr_l);
 
-		if (len < 0 || addr.nl_pid) {
+		if (len < 0) {
 			syslog(LOG_ERR, "recvfrom failed; pid:%u error:%d %s",
 					addr.nl_pid, errno, strerror(errno));
 			close(fd);
 			return -1;
 		}
 
+		if (addr.nl_pid) {
+			syslog(LOG_WARNING, "Received packet from untrusted pid:%u",
+					addr.nl_pid);
+			continue;
+		}
+
 		incoming_msg = (struct nlmsghdr *)vss_recv_buffer;
 
 		if (incoming_msg->nlmsg_type != NLMSG_DONE)
-- 
1.7.4.1


  parent reply	other threads:[~2013-04-23 20:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23 20:58 [PATCH 0/5] Tools: hv: snapshot K. Y. Srinivasan
2013-04-23 20:58 ` [PATCH 1/5] [PATCH 1/3] Tools: hv: fix warnings in hv_vss_daemon K. Y. Srinivasan
2013-04-23 20:35   ` Greg KH
2013-04-23 20:52     ` KY Srinivasan
2013-04-23 20:58   ` K. Y. Srinivasan [this message]
2013-04-23 20:58   ` [PATCH 3/5] [PATCH 3/3] tools: hv: use getmntent " K. Y. Srinivasan
2013-04-23 20:58   ` [PATCH 4/5] [PATCH 1/2] tools: hv: use FIFREEZE/FITHAW " K. Y. Srinivasan
2013-04-23 20:58   ` [PATCH 5/5] [PATCH 2/2] tools: hv: skip iso9660 mounts " K. Y. Srinivasan
  -- strict thread matches above, loose matches on Subject: below --
2013-04-23 12:57 [PATCH 0/5] Tools: hv: snapshot K. Y. Srinivasan
2013-04-23 12:58 ` [PATCH 1/5] [PATCH 1/3] Tools: hv: fix warnings in hv_vss_daemon K. Y. Srinivasan
2013-04-23 12:58   ` [PATCH 2/5] [PATCH 2/3] tools: hv: fix checks for origin of netlink message " K. Y. Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366750720-32667-2-git-send-email-kys@microsoft.com \
    --to=kys@microsoft.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.