Re: Rediff: Patch to minimize noise with snapshots in emc_clariion checker

[Christophe Varoqui <christophe.varoqui@gmail.com>]

On mar., 2013-04-23 at 10:45 +0000, Levy, Jerome wrote:
> Looks like the diff went the wrong way. Sorry for the inconvenience, resubmitting:
> 
Applied manually.

You definitively have a problem with your way to generate 'git am'-able
mails. You could try to apply those mails to a fresh clone to verify and
diagnose this problem.

Thanks all the same.


> --- 
> 
> Patch to stop emc_clariion_checker from logging messages when probes to snapshot LUNs occur. Notification is still available if logging is turned up (see condlog()) but normal probing of snapshots will no longer produce status messages. Path functionality on snapshot probes is unchanged.
> 
> Signed-off-by: Jerry Levy <jerome.levy@emc.com>
> 
> 
> --- ./libmultipath/checkers/emc_clariion.c.orig 2013-04-22 14:07:36.966548097 -0400
> +++ ./libmultipath/checkers/emc_clariion.c      2013-04-22 15:50:19.081555624 -0400
> @@ -15,6 +15,7 @@
>  #include "../libmultipath/sg_include.h"
>  #include "libsg.h"
>  #include "checkers.h"
> +#include "debug.h"
>  
>  #define INQUIRY_CMD     0x12
>  #define INQUIRY_CMDLEN  6
> @@ -198,9 +199,8 @@ int libcheck_check (struct checker * c)
>                                  * 02/04/03 not 05/25/01 on read.
>                                  */
>                                 SET_INACTIVE_SNAP(c);
> -                               MSG(c, "emc_clariion_checker: Active "
> -                                       "path to inactive snapshot WWN %s.",
> -                                       wwnstr);
> +                               condlog(3, "emc_clariion_checker: Active path to "
> +                                       "inactive snapshot WWN %s.", wwnstr);
>                         } else
>                                 MSG(c, "emc_clariion_checker: Read "
>                                         "error for WWN %s.  Sense data are "
> @@ -219,9 +219,8 @@ int libcheck_check (struct checker * c)
>         } else {
>                 if (IS_INACTIVE_SNAP(c)) {
>                         hexadecimal_to_ascii(ct->wwn, wwnstr);
> -                       MSG(c, "emc_clariion_checker: Passive "
> -                               "path to inactive snapshot WWN %s.",
> -                               wwnstr);
> +                       condlog(3, "emc_clariion_checker: Passive path to "
> +                               "inactive snapshot WWN %s.", wwnstr);
>                         ret = PATH_DOWN;
>                 } else {
>                         MSG(c,
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel